From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Jan Kara <jack@suse.cz>
Cc: tytso@mit.edu, adilger@sun.com, bzzz@sun.com, cmm@us.ibm.com,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Fix the soft lockup with multi block allocator.
Date: Wed, 9 Jan 2008 23:54:28 +0530 [thread overview]
Message-ID: <20080109182428.GC11852@skywalker> (raw)
In-Reply-To: <20080109121041.GA1013@atrey.karlin.mff.cuni.cz>
On Wed, Jan 09, 2008 at 01:10:41PM +0100, Jan Kara wrote:
> > With the multi block allocator when we don't have prealloc space we discard
> > @@ -3790,7 +3782,9 @@ repeat:
> >
> > /* if we still need more blocks and some PAs were used, try again */
> > if (free < needed && busy) {
> > + busy = 0;
> > ext4_unlock_group(sb, group);
> > + schedule_timeout(HZ);
> > goto repeat;
> > }
> Hmm, wouldn't just schedule() be enough here? That would give a good
> chance to other processes to proceed and we would avoid this artificial
> wait of 1s which is quite ugly IMO.
>
> Honza
But then who will wake up the task ?. I have the below comment added to
the patch in the patch queue.
/*
* We see this quiet rare. But if a particular workload is
* effected by this we may need to add a waitqueue
*/
-aneesh
next prev parent reply other threads:[~2008-01-09 18:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-21 11:09 [PATCH] ext4: Fix the soft lockup with multi block allocator Aneesh Kumar K.V
2007-12-21 11:21 ` Alex Tomas
2007-12-21 19:10 ` Andreas Dilger
2007-12-24 18:18 ` Alex Tomas
2007-12-24 18:45 ` Andreas Dilger
2008-01-09 12:10 ` Jan Kara
2008-01-09 18:24 ` Aneesh Kumar K.V [this message]
2008-01-09 18:44 ` Jan Kara
2008-01-09 19:11 ` Aneesh Kumar K.V
2008-01-09 22:01 ` Mingming Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080109182428.GC11852@skywalker \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=adilger@sun.com \
--cc=bzzz@sun.com \
--cc=cmm@us.ibm.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox