public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Tomas <alex.tomas@sun.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	tytso@mit.edu, cmm@us.ibm.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Fix the soft lockup with multi block allocator.
Date: Mon, 24 Dec 2007 21:18:45 +0300	[thread overview]
Message-ID: <476FF805.4050700@sun.com> (raw)
In-Reply-To: <20071221191020.GM3214@webber.adilger.int>

Andreas Dilger wrote:
> On Dec 21, 2007  16:39 +0530, Aneesh Kumar K.V wrote:
>> @@ -3790,7 +3782,9 @@ repeat:
>>  
>>  	/* if we still need more blocks and some PAs were used, try again */
>>  	if (free < needed && busy) {
>> +		busy = 0;
>>  		ext4_unlock_group(sb, group);
>> +		schedule_timeout(HZ);
>>  		goto repeat;
>>  	}
> 
> Is there nothing we could actually wait on instead of just sleeping for
> 1 second?

actually it was done for simplicity - in my tests busy PA happened quite rare.
I have no objection to improve this with special wait queue.

thanks, Alex

  reply	other threads:[~2007-12-24 18:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-21 11:09 [PATCH] ext4: Fix the soft lockup with multi block allocator Aneesh Kumar K.V
2007-12-21 11:21 ` Alex Tomas
2007-12-21 19:10 ` Andreas Dilger
2007-12-24 18:18   ` Alex Tomas [this message]
2007-12-24 18:45     ` Andreas Dilger
2008-01-09 12:10 ` Jan Kara
2008-01-09 18:24   ` Aneesh Kumar K.V
2008-01-09 18:44     ` Jan Kara
2008-01-09 19:11       ` Aneesh Kumar K.V
2008-01-09 22:01         ` Mingming Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=476FF805.4050700@sun.com \
    --to=alex.tomas@sun.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=cmm@us.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox