From: Theodore Tso <tytso@MIT.EDU>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>,
pspencer@fields.utoronto.ca
Subject: Re: [PATCH] e2fsprogs: error checking in blkid/devname.c
Date: Fri, 22 Feb 2008 11:33:31 -0500 [thread overview]
Message-ID: <20080222163331.GQ20118@mit.edu> (raw)
In-Reply-To: <47BEF575.40908@redhat.com>
On Fri, Feb 22, 2008 at 10:16:53AM -0600, Eric Sandeen wrote:
> From a quick chat with agk, it sounds like outright failure is
> appropriate. Sounds like most of the calls fail for reasons like ENOMEM
> (but it might be nice if it returned that, eh?)
So the question then is why is it that Phillip was able to seeing
failures when he was creating and deleting snapshots?
I don't mind having blkid return a failure, but it may not fix
Phillip's scenario which he listed in BZ #433857; yeah, he won't have
a core dump, which is good, but it might mean that some or all of the
dm volumes disappear from the blkid results.
- Ted
next prev parent reply other threads:[~2008-02-22 16:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 22:10 [PATCH] e2fsprogs: error checking in blkid/devname.c Eric Sandeen
2008-02-22 13:16 ` Theodore Tso
2008-02-22 15:02 ` Eric Sandeen
2008-02-22 15:44 ` Theodore Tso
2008-02-22 16:16 ` Eric Sandeen
2008-02-22 16:33 ` Theodore Tso [this message]
2008-02-22 16:52 ` Eric Sandeen
2008-02-22 18:22 ` Theodore Tso
2008-02-22 18:10 ` Philip Spencer
2008-02-22 18:25 ` Theodore Tso
2008-02-22 15:46 ` Philip Spencer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080222163331.GQ20118@mit.edu \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=pspencer@fields.utoronto.ca \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox