public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@MIT.EDU>
To: Philip Spencer <pspencer@fields.utoronto.ca>
Cc: Eric Sandeen <sandeen@redhat.com>,
	ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] e2fsprogs: error checking in blkid/devname.c
Date: Fri, 22 Feb 2008 13:25:55 -0500	[thread overview]
Message-ID: <20080222182555.GS20118@mit.edu> (raw)
In-Reply-To: <Pine.LNX.4.64.0802221305410.11313@lpc1.fields.utoronto.ca>

On Fri, Feb 22, 2008 at 01:10:40PM -0500, Philip Spencer wrote:
> You know what -- I went back and double-checked all the logs, and somehow
> or other I must have recorded a timestamp wrong as 3:19:21 instead of 
> 3:19:51.
>
> The segfault did in fact happen at 3:19:51 a.m. which is exactly the same 
> time as my backup script moved on to the next filesystem.
>
> So, it occurred during the unmount and lvremove of the snapshot volume.
> It is, then, entirely expected that the device-mapper routines would return 
> an error if the device no longer existed when the task was run.
>
> My apologies for mixing up the timestamps! And no bug in device-mapper, 
> just the one in e2fsprogs whch segfaulted in this circumstance instead of 
> dropping the device from its list. Having it fail outright, and not list 
> the device at all, is the correct behaviour for this situation -- just as 
> if the device had already been removed before the blkid routines were run.

OK, that's helpful, to know.  Thanks!!!

						- Ted

  reply	other threads:[~2008-02-22 18:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-21 22:10 [PATCH] e2fsprogs: error checking in blkid/devname.c Eric Sandeen
2008-02-22 13:16 ` Theodore Tso
2008-02-22 15:02   ` Eric Sandeen
2008-02-22 15:44     ` Theodore Tso
2008-02-22 16:16       ` Eric Sandeen
2008-02-22 16:33         ` Theodore Tso
2008-02-22 16:52           ` Eric Sandeen
2008-02-22 18:22             ` Theodore Tso
2008-02-22 18:10           ` Philip Spencer
2008-02-22 18:25             ` Theodore Tso [this message]
2008-02-22 15:46   ` Philip Spencer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080222182555.GS20118@mit.edu \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=pspencer@fields.utoronto.ca \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox