From: Jan Kara <jack@suse.cz>
To: Josef Bacik <jbacik@redhat.com>
Cc: linux-ext4@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC PATCH 1/1] add a jbd option to force an unclean journal state
Date: Tue, 4 Mar 2008 20:01:09 +0100 [thread overview]
Message-ID: <20080304190109.GD24335@duck.suse.cz> (raw)
In-Reply-To: <200803041339.42544.jbacik@redhat.com>
Hi,
On Tue 04-03-08 13:39:41, Josef Bacik wrote:
> jbd and I want a way to verify that I'm not screwing anything up in the
> process, and this is what I came up with. Basically this option would only be
> used in the case where someone mounts an ext3 image or fs, does a specific IO
> operation (create 100 files, write data to a few files etc), unmounts the fs
> and remounts so that jbd does its journal recovery and then check the status of
> the fs to make sure its exactly the way its expected to be. I'm not entirely
> sure how usefull of an option like this would be (or if I did it right :) ),
> but I thought I'd throw it out there in case anybody thinks it may be useful,
> and in case there is some case that I'm missing so I can fix it and better make
> sure I don't mess anything up while doing stuff. Basically this patch keeps us
> from resetting the journal's tail/transaction sequence when we destroy the
> journal so when we mount the fs again it will look like we didn't unmount
> properly and recovery will occur. Any comments are much appreciated,
Actually, there is a different way how we've done checking like this (and
I think also more useful), at least for ext3. Basically you mounted a
filesysteem with some timeout and after the timeout, device was forced
read-only. And then you've checked that the fs is consistent after journal
replay. I think Andrew had the patches somewhere...
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2008-03-04 19:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 18:39 [RFC PATCH 1/1] add a jbd option to force an unclean journal state Josef Bacik
2008-03-04 19:01 ` Jan Kara [this message]
2008-03-04 23:58 ` Andrew Morton
2008-03-05 2:46 ` Eric Sandeen
2008-03-05 7:34 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080304190109.GD24335@duck.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=jbacik@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox