From: Andreas Dilger <adilger@sun.com>
To: akpm@linux-foundation.org
Cc: mm-commits@vger.kernel.org, duaneg@dghda.com, linux-ext4@vger.kernel.org
Subject: Re: + ext2-dont-inherit-inappropriate-inode-flags-from-parent.patch added to -mm tree
Date: Wed, 04 Jun 2008 23:30:43 -0600 [thread overview]
Message-ID: <20080605053043.GO2961@webber.adilger.int> (raw)
In-Reply-To: <200806050437.m554bqsc025546@imap1.linux-foundation.org>
On Jun 04, 2008 21:37 -0700, Andrew Morton wrote:
> +/* Flags that should be inherited by new inodes from their parent. */
> +#define EXT2_FL_INHERITED ~(EXT2_DIRTY_FL | EXT2_ECOMPR_FL | EXT2_BTREE_FL |\
> + EXT2_INDEX_FL | EXT2_IMAGIC_FL | EXT2_TOPDIR_FL)
This doesn't make things much better, unless it is just as a stop-gap
measure to get into the kernel while there is more discussion about which
flags need to be inherited... Duane did mention follow-up patches, so
I have no real objection to this patch as-is, so long as we don't consider
the matter closed.
Minor nit - "EXT2_BTREE_FL" is the long-deprecated name for "EXT2_INDEX_FL",
so we may as well just avoid it entirely here.
Yes, this patch avoids a few more of the cases that are bad, but will
again be incorrect as soon as some new flag enters use.
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
next prev parent reply other threads:[~2008-06-05 5:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 4:37 + ext2-dont-inherit-inappropriate-inode-flags-from-parent.patch added to -mm tree akpm
2008-06-05 5:30 ` Andreas Dilger [this message]
2008-06-05 5:37 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2008-12-07 6:18 akpm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080605053043.GO2961@webber.adilger.int \
--to=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=duaneg@dghda.com \
--cc=linux-ext4@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox