From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Theodore Tso <tytso@MIT.EDU>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2fsprogs: Fix tst_extents output on bigendian machine.
Date: Sat, 19 Jul 2008 11:51:40 +0530 [thread overview]
Message-ID: <20080719062140.GB823@skywalker> (raw)
In-Reply-To: <20080719011921.GB18506@mit.edu>
On Fri, Jul 18, 2008 at 09:19:21PM -0400, Theodore Tso wrote:
> On Fri, Jul 18, 2008 at 05:35:40PM +0530, Aneesh Kumar K.V wrote:
> > Add type __le16, __le32, and __le64 to indicate that
> > the variables need to be byteswaped when using.
>
> I took out the __le16 types. The artificial types don't really buy us
> much (a lot of work would be needed before we could use sparse on
> e2fsprogs) and for now just makes it harder to read the header file.
> I removed the __le types deliberately.
>
The reason for me to use __le* types was to explicitly document that
these variables need to be accessed through the conversion APIs. In this
case I had to search rest of the code to figure out whether all of them
need to be accessed via the conversion APIs or not. Getting sparse to
run on e2fsprogs can be a long term goal. But more important is to
indicate how these variables need to be accessed in the program.
-aneesh
next prev parent reply other threads:[~2008-07-19 6:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 12:05 [PATCH] e2fsprogs: Fix tst_extents output on bigendian machine Aneesh Kumar K.V
2008-07-19 1:19 ` Theodore Tso
2008-07-19 6:21 ` Aneesh Kumar K.V [this message]
2008-07-21 5:07 ` Andreas Dilger
2008-07-21 6:03 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080719062140.GB823@skywalker \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox