From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Andreas Dilger <adilger@sun.com>
Cc: tytso@mit.edu, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2fsprogs: Fix tst_extents output on bigendian machine.
Date: Mon, 21 Jul 2008 11:33:00 +0530 [thread overview]
Message-ID: <20080721060300.GB8788@skywalker> (raw)
In-Reply-To: <20080721050755.GD3370@webber.adilger.int>
On Sun, Jul 20, 2008 at 11:07:55PM -0600, Andreas Dilger wrote:
> On Jul 18, 2008 17:35 +0530, Aneesh Kumar wrote:
> > static void dbg_show_header(struct ext3_extent_header *eh)
> > {
> > printf("header: magic=%x entries=%u max=%u depth=%u generation=%u\n",
> > - eh->eh_magic, eh->eh_entries, eh->eh_max, eh->eh_depth,
> > - eh->eh_generation);
> > + ext2fs_le16_to_cpu(eh->eh_magic),
> > + ext2fs_le16_to_cpu(eh->eh_entries),
> > + ext2fs_le16_to_cpu(eh->eh_max),
> > + ext2fs_le16_to_cpu(eh->eh_depth),
> > + ext2fs_le32_to_cpu(eh->eh_generation));
>
> Please fix indenting to align this with the '(' on the preceeding line.
>
I am always confused what is the suggested coding guideline here. I
always use TAB instead of space and use TAB aligned offsets for the
continuation line.
-aneesh
prev parent reply other threads:[~2008-07-21 6:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 12:05 [PATCH] e2fsprogs: Fix tst_extents output on bigendian machine Aneesh Kumar K.V
2008-07-19 1:19 ` Theodore Tso
2008-07-19 6:21 ` Aneesh Kumar K.V
2008-07-21 5:07 ` Andreas Dilger
2008-07-21 6:03 ` Aneesh Kumar K.V [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080721060300.GB8788@skywalker \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox