* BUG: using smp_processor_id() in preemptible
@ 2008-08-20 5:34 Aneesh Kumar K.V
2008-08-21 4:17 ` Eric Sandeen
0 siblings, 1 reply; 2+ messages in thread
From: Aneesh Kumar K.V @ 2008-08-20 5:34 UTC (permalink / raw)
To: Eric Sandeen; +Cc: ext4 development
BUG: using smp_processor_id() in preemptible [00000000] code:
fsstress/20995
caller is ext4_mb_initialize_context+0x20c/0x22c
Pid: 20995, comm: fsstress Not tainted 2.6.27-rc3-autokern1 #1
[<c0294a2f>] debug_smp_processor_id+0x9f/0xb8
[<c01e523d>] ext4_mb_initialize_context+0x20c/0x22c
[<c01ea017>] ext4_mb_new_blocks+0x17c/0x715
[<c0136b43>] ? trace_hardirqs_on+0xb/0xd
[<c01e23f2>] ext4_ext_get_blocks+0xbaf/0xde1
[<c0137d20>] ? __lock_acquire+0x61e/0x674
[<c0137d20>] ? __lock_acquire+0x61e/0x674
[<c01d464a>] ext4_get_blocks_wrap+0xce/0x1eb
[<c01dfaba>] ext4_fallocate+0x135/0x27d
[<c016472d>] ? fget+0x1d/0xd3
[<c01647aa>] ? fget+0x9a/0xd3
[<c01623a4>] sys_fallocate+0xce/0xf3
[<c0102bb9>] sysenter_do_call+0x12/0x35
=======================
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: BUG: using smp_processor_id() in preemptible
2008-08-20 5:34 BUG: using smp_processor_id() in preemptible Aneesh Kumar K.V
@ 2008-08-21 4:17 ` Eric Sandeen
0 siblings, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2008-08-21 4:17 UTC (permalink / raw)
To: Aneesh Kumar K.V; +Cc: ext4 development
Aneesh Kumar K.V wrote:
> BUG: using smp_processor_id() in preemptible [00000000] code:
> fsstress/20995
> caller is ext4_mb_initialize_context+0x20c/0x22c
> Pid: 20995, comm: fsstress Not tainted 2.6.27-rc3-autokern1 #1
> [<c0294a2f>] debug_smp_processor_id+0x9f/0xb8
> [<c01e523d>] ext4_mb_initialize_context+0x20c/0x22c
> [<c01ea017>] ext4_mb_new_blocks+0x17c/0x715
> [<c0136b43>] ? trace_hardirqs_on+0xb/0xd
> [<c01e23f2>] ext4_ext_get_blocks+0xbaf/0xde1
> [<c0137d20>] ? __lock_acquire+0x61e/0x674
> [<c0137d20>] ? __lock_acquire+0x61e/0x674
> [<c01d464a>] ext4_get_blocks_wrap+0xce/0x1eb
> [<c01dfaba>] ext4_fallocate+0x135/0x27d
> [<c016472d>] ? fget+0x1d/0xd3
> [<c01647aa>] ? fget+0x9a/0xd3
> [<c01623a4>] sys_fallocate+0xce/0xf3
> [<c0102bb9>] sysenter_do_call+0x12/0x35
> =======================
whoops, ok, I should probably convert it to use raw_smp_processor_id; I
don't think we care if we get pre-empted and the cpu changes; we use the
cpu id exactly once to grab it from the array, I think we don't need any
atomicity. I'll convert to raw_smp_processor_id() to avoid the debug
check, unless anyone sees a problem with that ...
-Eric
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-08-21 4:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-20 5:34 BUG: using smp_processor_id() in preemptible Aneesh Kumar K.V
2008-08-21 4:17 ` Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox