* [PATCH] include <linux/fs.h> into linux/ext2_fs.h @ 2008-09-10 11:22 Kirill A. Shutemov 2008-09-10 11:27 ` Christoph Hellwig 0 siblings, 1 reply; 8+ messages in thread From: Kirill A. Shutemov @ 2008-09-10 11:22 UTC (permalink / raw) To: linux-kernel; +Cc: Kirill A. Shutemov, Andrew Morton, linux-ext4 linux/fs.h defines FS_IOC* needed by linux/ext2_fs.h Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: <linux-ext4@vger.kernel.org> --- include/linux/ext2_fs.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/ext2_fs.h b/include/linux/ext2_fs.h index 2efe7b8..f23ba68 100644 --- a/include/linux/ext2_fs.h +++ b/include/linux/ext2_fs.h @@ -18,6 +18,7 @@ #include <linux/types.h> #include <linux/magic.h> +#include <linux/fs.h> /* * The second extended filesystem constants/structures -- 1.5.6.5.GIT ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] include <linux/fs.h> into linux/ext2_fs.h 2008-09-10 11:22 [PATCH] include <linux/fs.h> into linux/ext2_fs.h Kirill A. Shutemov @ 2008-09-10 11:27 ` Christoph Hellwig 2008-09-10 11:40 ` Kirill A. Shutemov 0 siblings, 1 reply; 8+ messages in thread From: Christoph Hellwig @ 2008-09-10 11:27 UTC (permalink / raw) To: Kirill A. Shutemov; +Cc: linux-kernel, Andrew Morton, linux-ext4 On Wed, Sep 10, 2008 at 02:22:03PM +0300, Kirill A. Shutemov wrote: > linux/fs.h defines FS_IOC* needed by linux/ext2_fs.h And who cares? ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] include <linux/fs.h> into linux/ext2_fs.h 2008-09-10 11:27 ` Christoph Hellwig @ 2008-09-10 11:40 ` Kirill A. Shutemov 2008-09-10 11:40 ` Christoph Hellwig 0 siblings, 1 reply; 8+ messages in thread From: Kirill A. Shutemov @ 2008-09-10 11:40 UTC (permalink / raw) To: Christoph Hellwig Cc: linux-kernel, Andrew Morton, linux-ext4, David Howells, Jens Axboe [-- Attachment #1: Type: text/plain, Size: 416 bytes --] On Wed, Sep 10, 2008 at 07:27:09AM -0400, Christoph Hellwig wrote: > On Wed, Sep 10, 2008 at 02:22:03PM +0300, Kirill A. Shutemov wrote: > > linux/fs.h defines FS_IOC* needed by linux/ext2_fs.h > > And who cares? It breaks building pam_mktemp at least. It's regression introduced by commit 36695673b. -- Regards, Kirill A. Shutemov + Belarus, Minsk + ALT Linux Team, http://www.altlinux.com/ [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 197 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] include <linux/fs.h> into linux/ext2_fs.h 2008-09-10 11:40 ` Kirill A. Shutemov @ 2008-09-10 11:40 ` Christoph Hellwig 2008-09-10 11:49 ` Kirill A. Shutemov 0 siblings, 1 reply; 8+ messages in thread From: Christoph Hellwig @ 2008-09-10 11:40 UTC (permalink / raw) To: Kirill A. Shutemov Cc: Christoph Hellwig, linux-kernel, Andrew Morton, linux-ext4, David Howells, Jens Axboe On Wed, Sep 10, 2008 at 02:40:12PM +0300, Kirill A. Shutemov wrote: > On Wed, Sep 10, 2008 at 07:27:09AM -0400, Christoph Hellwig wrote: > > On Wed, Sep 10, 2008 at 02:22:03PM +0300, Kirill A. Shutemov wrote: > > > linux/fs.h defines FS_IOC* needed by linux/ext2_fs.h > > > > And who cares? > > It breaks building pam_mktemp at least. pam_mktemp should not use <linux/ext2_fs.h>, but rather <ext2fs/ext2_fs.h>. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] include <linux/fs.h> into linux/ext2_fs.h 2008-09-10 11:40 ` Christoph Hellwig @ 2008-09-10 11:49 ` Kirill A. Shutemov 2008-09-10 13:39 ` Eric Sandeen 0 siblings, 1 reply; 8+ messages in thread From: Kirill A. Shutemov @ 2008-09-10 11:49 UTC (permalink / raw) To: Christoph Hellwig Cc: linux-kernel, Andrew Morton, linux-ext4, David Howells, Jens Axboe [-- Attachment #1: Type: text/plain, Size: 697 bytes --] On Wed, Sep 10, 2008 at 07:40:42AM -0400, Christoph Hellwig wrote: > On Wed, Sep 10, 2008 at 02:40:12PM +0300, Kirill A. Shutemov wrote: > > On Wed, Sep 10, 2008 at 07:27:09AM -0400, Christoph Hellwig wrote: > > > On Wed, Sep 10, 2008 at 02:22:03PM +0300, Kirill A. Shutemov wrote: > > > > linux/fs.h defines FS_IOC* needed by linux/ext2_fs.h > > > > > > And who cares? Do you think it isn't error? > > It breaks building pam_mktemp at least. > > pam_mktemp should not use <linux/ext2_fs.h>, but rather > <ext2fs/ext2_fs.h>. Why linux/ext2_fs.h does export to userspace? -- Regards, Kirill A. Shutemov + Belarus, Minsk + ALT Linux Team, http://www.altlinux.com/ [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 197 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] include <linux/fs.h> into linux/ext2_fs.h 2008-09-10 11:49 ` Kirill A. Shutemov @ 2008-09-10 13:39 ` Eric Sandeen 2008-09-10 13:47 ` Kirill A. Shutemov 0 siblings, 1 reply; 8+ messages in thread From: Eric Sandeen @ 2008-09-10 13:39 UTC (permalink / raw) To: Kirill A. Shutemov Cc: Christoph Hellwig, linux-kernel, Andrew Morton, linux-ext4, David Howells, Jens Axboe Kirill A. Shutemov wrote: > On Wed, Sep 10, 2008 at 07:40:42AM -0400, Christoph Hellwig wrote: >> On Wed, Sep 10, 2008 at 02:40:12PM +0300, Kirill A. Shutemov wrote: >>> On Wed, Sep 10, 2008 at 07:27:09AM -0400, Christoph Hellwig wrote: >>>> On Wed, Sep 10, 2008 at 02:22:03PM +0300, Kirill A. Shutemov wrote: >>>>> linux/fs.h defines FS_IOC* needed by linux/ext2_fs.h >>>> And who cares? > > Do you think it isn't error? > >>> It breaks building pam_mktemp at least. >> pam_mktemp should not use <linux/ext2_fs.h>, but rather >> <ext2fs/ext2_fs.h>. That's right. > Why linux/ext2_fs.h does export to userspace? > it does? $ grep header-y include/linux/Kbuild | wc -l 163 $ grep header-y include/linux/Kbuild | grep ext2 $ I think it does not. -Eric ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] include <linux/fs.h> into linux/ext2_fs.h 2008-09-10 13:39 ` Eric Sandeen @ 2008-09-10 13:47 ` Kirill A. Shutemov 2008-09-10 14:57 ` Eric Sandeen 0 siblings, 1 reply; 8+ messages in thread From: Kirill A. Shutemov @ 2008-09-10 13:47 UTC (permalink / raw) To: Eric Sandeen Cc: Christoph Hellwig, linux-kernel, Andrew Morton, linux-ext4, David Howells, Jens Axboe [-- Attachment #1: Type: text/plain, Size: 1088 bytes --] On Wed, Sep 10, 2008 at 08:39:00AM -0500, Eric Sandeen wrote: > Kirill A. Shutemov wrote: > > On Wed, Sep 10, 2008 at 07:40:42AM -0400, Christoph Hellwig wrote: > >> On Wed, Sep 10, 2008 at 02:40:12PM +0300, Kirill A. Shutemov wrote: > >>> On Wed, Sep 10, 2008 at 07:27:09AM -0400, Christoph Hellwig wrote: > >>>> On Wed, Sep 10, 2008 at 02:22:03PM +0300, Kirill A. Shutemov wrote: > >>>>> linux/fs.h defines FS_IOC* needed by linux/ext2_fs.h > >>>> And who cares? > > > > Do you think it isn't error? > > > >>> It breaks building pam_mktemp at least. > >> pam_mktemp should not use <linux/ext2_fs.h>, but rather > >> <ext2fs/ext2_fs.h>. > > That's right. > > > Why linux/ext2_fs.h does export to userspace? > > > > it does? > > $ grep header-y include/linux/Kbuild | wc -l > 163 > $ grep header-y include/linux/Kbuild | grep ext2 > $ > > I think it does not. It does: $ grep unifdef-y include/linux/Kbuild | grep ext2 unifdef-y += ext2_fs.h -- Regards, Kirill A. Shutemov + Belarus, Minsk + ALT Linux Team, http://www.altlinux.com/ [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 197 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] include <linux/fs.h> into linux/ext2_fs.h 2008-09-10 13:47 ` Kirill A. Shutemov @ 2008-09-10 14:57 ` Eric Sandeen 0 siblings, 0 replies; 8+ messages in thread From: Eric Sandeen @ 2008-09-10 14:57 UTC (permalink / raw) To: Kirill A. Shutemov Cc: Christoph Hellwig, linux-kernel, Andrew Morton, linux-ext4, David Howells, Jens Axboe Kirill A. Shutemov wrote: > On Wed, Sep 10, 2008 at 08:39:00AM -0500, Eric Sandeen wrote: >> I think it does not. > > It does: > > $ grep unifdef-y include/linux/Kbuild | grep ext2 > unifdef-y += ext2_fs.h Oops, I stand corrected :) -Eric ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2008-09-10 14:57 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2008-09-10 11:22 [PATCH] include <linux/fs.h> into linux/ext2_fs.h Kirill A. Shutemov 2008-09-10 11:27 ` Christoph Hellwig 2008-09-10 11:40 ` Kirill A. Shutemov 2008-09-10 11:40 ` Christoph Hellwig 2008-09-10 11:49 ` Kirill A. Shutemov 2008-09-10 13:39 ` Eric Sandeen 2008-09-10 13:47 ` Kirill A. Shutemov 2008-09-10 14:57 ` Eric Sandeen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox