public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Fasheh <mfasheh@suse.com>
To: Andreas Dilger <adilger@sun.com>
Cc: Eric Sandeen <esandeen@redhat.com>,
	linux-ext4@vger.kernel.org, Kalpak Shah <Kalpak.Shah@Sun.COM>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: FIEMAP patches
Date: Wed, 10 Sep 2008 05:40:05 -0700	[thread overview]
Message-ID: <20080910124005.GA4563@wotan.suse.de> (raw)
In-Reply-To: <20080825202250.GY3392@webber.adilger.int>

On Mon, Aug 25, 2008 at 02:22:50PM -0600, Andreas Dilger wrote:
> I read through the entire previous FIEMAP thread (phew!) and it boils
> down mostly to:
> 
> s/FIEMAP_FLAG_NO_DIRECT/FIEMAP_FLAG_NO_BYPASS/
> 
> > * FIEMAP_EXTENT_UNWRITTEN                                                    
> > Unwritten extent - the extent is allocated but it's data has not been        
> > initialized.  This indicates the extent's data will be all zero.             
>                                                                                
> This should say "will be all zero if read through the filesystem              
> but the contents are undefined if read directly from the device."
> 
> There was also an update to the ext4 patch from Kalpak for handling
> EA-in-inode at the same time as an external inode.

Hmm, I didn't find this in my mailbox... The Ext4 patch I had doesn't apply
any more either :( I think one of you all is going to have to send an
update.


> Eric, Mark,
> could one of you please just submit the patches to Andrew for inclusion.
> I think there was plenty of debate already, with very little significant
> benefit except suggesting different names for some of the flags.

Ok, sorry again for the delay. I am at a conference this week, then on
vacation, then back to another conference, so I am having a rather busy
month. None the less, I managed to bring the fiemap patches up to
2.6.27-rc6, with the changes discussed.

They are in git:

git://git.kernel.org/pub/scm/linux/kernel/git/mfasheh/ocfs2.git fiemap

Individual patches will be mailed in response to this message.


Andrew, are these patches ok for a spin in -mm? I agree with Andreas that
this has been discussed to death, with very little benefit being extracted
from the latest round.
	--Mark

--
Mark Fasheh

  parent reply	other threads:[~2008-09-10 12:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-25 20:22 FIEMAP patches Andreas Dilger
2008-08-26  6:22 ` Mark Fasheh
2008-08-26  6:57   ` Andreas Dilger
2008-09-10 12:40 ` Mark Fasheh [this message]
2008-09-10 12:49   ` [PATCH 0/3] Fiemap, an extent mapping ioctl Mark Fasheh
2008-09-10 13:47     ` Christoph Hellwig
2008-09-10 14:07       ` Theodore Tso
2008-09-10 14:11         ` Christoph Hellwig
2008-09-10 20:33           ` Andreas Dilger
2008-09-10 16:10       ` Mark Fasheh
2008-09-10 16:20         ` Christoph Hellwig
2008-09-10 18:46     ` Andrew Morton
2008-09-10 19:46       ` Andreas Dilger
2008-09-10 12:49   ` [PATCH 1/3] vfs: vfs-level fiemap interface Mark Fasheh
2008-09-10 12:50   ` [PATCH 2/3] generic block based fiemap implementation Mark Fasheh
2008-09-10 12:50   ` [PATCH 3/3] ocfs2: fiemap support Mark Fasheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080910124005.GA4563@wotan.suse.de \
    --to=mfasheh@suse.com \
    --cc=Kalpak.Shah@Sun.COM \
    --cc=adilger@sun.com \
    --cc=akpm@linux-foundation.org \
    --cc=esandeen@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox