From: Andreas Dilger <adilger@sun.com>
To: Mark Fasheh <mfasheh@suse.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Theodore Tso <tytso@MIT.EDU>,
Anton Altaparmakov <aia21@cam.ac.uk>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
akpm@linuxfoundation.org
Subject: Re: [PATCH 1/4] vfs: vfs-level fiemap interface
Date: Mon, 15 Sep 2008 23:51:26 -0700 [thread overview]
Message-ID: <20080916065126.GI3241@webber.adilger.int> (raw)
In-Reply-To: <20080915175305.GS4563@wotan.suse.de>
On Sep 15, 2008 10:53 -0700, Mark Fasheh wrote:
> On Mon, Sep 15, 2008 at 10:49:48AM -0400, Christoph Hellwig wrote:
> > I agree to you (or someone elses - don't remember anymore) suggestion
> > to put in more padding so we can add fields later. I strongly disagree
> > putting in features now that we neither have a user, nor a usecase or
> > testcase for.
>
> So, how about another 64 bits of padding in struct fiemap_extent? That could
> help cover future uses like compression, which might require another 64 bit
> offset field - we only have 32 bits of reserved space there right now.
I'd be happy to see it.
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
next prev parent reply other threads:[~2008-09-16 6:51 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-13 18:47 YET ANOTHER resend of the fiemap patches Theodore Ts'o
2008-09-13 18:49 ` [PATCH 1/4] vfs: vfs-level fiemap interface Theodore Ts'o
2008-09-13 18:49 ` [PATCH 2/4] ocfs2: fiemap support Theodore Ts'o
2008-09-13 18:49 ` [PATCH 3/4] generic block based fiemap implementation Theodore Ts'o
2008-09-13 18:49 ` [PATCH 4/4] Hook ext4 to the vfs fiemap interface Theodore Ts'o
2008-09-13 21:17 ` [PATCH 1/4] vfs: vfs-level " Anton Altaparmakov
2008-09-13 21:29 ` Theodore Tso
2008-09-13 21:45 ` Matthew Wilcox
2008-09-13 22:41 ` Theodore Tso
2008-09-13 21:59 ` Anton Altaparmakov
2008-09-14 13:51 ` Christoph Hellwig
2008-09-14 13:48 ` Christoph Hellwig
2008-09-14 17:58 ` Theodore Tso
2008-09-15 14:49 ` Christoph Hellwig
2008-09-15 17:53 ` Mark Fasheh
2008-09-16 6:51 ` Andreas Dilger [this message]
2008-09-16 21:31 ` Theodore Tso
2008-09-20 16:47 ` Josef 'Jeff' Sipek
2008-09-29 1:07 ` Theodore Tso
2008-09-29 21:13 ` Mark Fasheh
2008-09-29 22:10 ` Theodore Tso
2008-09-14 13:47 ` Christoph Hellwig
2008-09-14 18:01 ` Theodore Tso
2008-09-14 18:08 ` Christoph Hellwig
2008-09-14 19:58 ` Theodore Tso
2008-09-15 14:47 ` Christoph Hellwig
2008-09-16 6:49 ` Andreas Dilger
2008-09-16 22:03 ` Theodore Tso
2008-09-17 14:18 ` Jörn Engel
2008-09-17 15:02 ` Jamie Lokier
2008-09-17 15:25 ` Theodore Tso
2008-09-19 14:05 ` Chris Mason
2008-09-19 17:38 ` Jamie Lokier
2008-09-20 7:43 ` Dave Chinner
2008-09-20 13:50 ` Chris Mason
2008-09-20 15:36 ` Jamie Lokier
2008-09-20 15:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080916065126.GI3241@webber.adilger.int \
--to=adilger@sun.com \
--cc=aia21@cam.ac.uk \
--cc=akpm@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=tytso@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox