public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
* [BUILD FAILURE][PATCH] Export symbol log_start_commit. ext3 needs it.
@ 2009-11-12  5:36 Nikanth Karthikesan
  2009-11-12  9:37 ` Jan Kara
  0 siblings, 1 reply; 2+ messages in thread
From: Nikanth Karthikesan @ 2009-11-12  5:36 UTC (permalink / raw)
  To: linux-kernel; +Cc: linux-ext4, Andrew Morton, Andreas Dilger, Jan Kara

The linus git fails to build with the message
ERROR: "log_start_commit" [fs/ext3/ext3.ko] undefined!
Top commit id: aa021baa3295fa6e3f367d80f8955dd5176656eb

Export log_start_commit to modules. ext3 needs it to be built
as a module.

Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>

---

diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
index 49d5cd6..2e13cf3 100644
--- a/fs/jbd/journal.c
+++ b/fs/jbd/journal.c
@@ -72,6 +72,7 @@ EXPORT_SYMBOL(journal_abort);
 EXPORT_SYMBOL(journal_errno);
 EXPORT_SYMBOL(journal_ack_err);
 EXPORT_SYMBOL(journal_clear_err);
+EXPORT_SYMBOL(log_start_commit);
 EXPORT_SYMBOL(log_wait_commit);
 EXPORT_SYMBOL(journal_start_commit);
 EXPORT_SYMBOL(journal_force_commit_nested);

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [BUILD FAILURE][PATCH] Export symbol log_start_commit. ext3 needs it.
  2009-11-12  5:36 [BUILD FAILURE][PATCH] Export symbol log_start_commit. ext3 needs it Nikanth Karthikesan
@ 2009-11-12  9:37 ` Jan Kara
  0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2009-11-12  9:37 UTC (permalink / raw)
  To: Nikanth Karthikesan
  Cc: linux-kernel, linux-ext4, Andrew Morton, Andreas Dilger, Jan Kara

On Thu 12-11-09 11:06:52, Nikanth Karthikesan wrote:
> The linus git fails to build with the message
> ERROR: "log_start_commit" [fs/ext3/ext3.ko] undefined!
> Top commit id: aa021baa3295fa6e3f367d80f8955dd5176656eb
> 
> Export log_start_commit to modules. ext3 needs it to be built
> as a module.
> 
> Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
  Thanks! I've already merged a fix.

							Honza
> 
> ---
> 
> diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
> index 49d5cd6..2e13cf3 100644
> --- a/fs/jbd/journal.c
> +++ b/fs/jbd/journal.c
> @@ -72,6 +72,7 @@ EXPORT_SYMBOL(journal_abort);
>  EXPORT_SYMBOL(journal_errno);
>  EXPORT_SYMBOL(journal_ack_err);
>  EXPORT_SYMBOL(journal_clear_err);
> +EXPORT_SYMBOL(log_start_commit);
>  EXPORT_SYMBOL(log_wait_commit);
>  EXPORT_SYMBOL(journal_start_commit);
>  EXPORT_SYMBOL(journal_force_commit_nested);
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-11-12  9:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-12  5:36 [BUILD FAILURE][PATCH] Export symbol log_start_commit. ext3 needs it Nikanth Karthikesan
2009-11-12  9:37 ` Jan Kara

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox