From: Stephen Hemminger <shemminger@vyatta.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] ext2: clear uptodate flag on super block I/O error (v2)
Date: Thu, 19 Nov 2009 10:13:17 -0800 [thread overview]
Message-ID: <20091119101317.34791e83@nehalam> (raw)
In-Reply-To: <20091119151953.GA2943@atrey.karlin.mff.cuni.cz>
On Thu, 19 Nov 2009 16:19:53 +0100
Jan Kara <jack@suse.cz> wrote:
> > + if (buffer_write_io_error(sbh)) {
> > + /*
> > + * This happens if USB or floppy device is yanked out.
> > + * Maybe user put device back in so warn and update again.
> > + */
> > + printk(KERN_ERR
> > + "EXT2-fs: previous I/O error to superblock detected\n");
> > + clear_buffer_write_io_error(sbh);
> > + set_buffer_uptodate(sbh);
> It's not much about puting the device back. It's really just about
> avoiding the warning in mark_buffer_dirty(). So I'd just silently
> set_buffer_uptodate and be done with it. For superblock we are darn sure
> that in memory copy is the one that has the latest data :)
This code mirrors ext4_commit_super, why should ext2 be any different?
next prev parent reply other threads:[~2009-11-19 18:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091117174617.285298261@vyatta.com>
2009-11-17 17:46 ` [PATCH 1/2] ext2: clear uptodate flag on super block I/O error (v2) Stephen Hemminger
2009-11-19 15:19 ` Jan Kara
2009-11-19 18:13 ` Stephen Hemminger [this message]
2009-11-20 9:23 ` Jan Kara
2009-11-17 17:46 ` [PATCH 2/2] ext2: add wait flag support to sync_fs Stephen Hemminger
2009-11-19 15:34 ` Jan Kara
2009-11-20 10:36 ` Christoph Hellwig
2009-11-20 17:08 ` Stephen Hemminger
2009-11-20 21:06 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091119101317.34791e83@nehalam \
--to=shemminger@vyatta.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox