From: Stephen Hemminger <shemminger@vyatta.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@suse.cz>, linux-ext4@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH 2/2] ext2: add wait flag support to sync_fs
Date: Fri, 20 Nov 2009 09:08:58 -0800 [thread overview]
Message-ID: <20091120090858.62ae15b3@nehalam> (raw)
In-Reply-To: <20091120103622.GA29143@infradead.org>
On Fri, 20 Nov 2009 05:36:22 -0500
Christoph Hellwig <hch@infradead.org> wrote:
> On Thu, Nov 19, 2009 at 04:34:19PM +0100, Jan Kara wrote:
> > BTW: Christoph, why did you choose to call ext2_sync_fs with wait == 1
> > from ext2_write_super()? I'd think (and looking into callsites seem to
> > confirm that) that ->write_super() was meant to be asynchronous...
>
> No particular reason - the argument wasn't and still isn't used in ext2.
> And yes, now that ->sync_fs is mandatory ->write_super should be
> asynchronous.
>
Shouldn't super block (and all other) updates be synchronous if ext2
is mounted with SYNC and DIRSYNC?
--
next prev parent reply other threads:[~2009-11-20 17:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091117174617.285298261@vyatta.com>
2009-11-17 17:46 ` [PATCH 1/2] ext2: clear uptodate flag on super block I/O error (v2) Stephen Hemminger
2009-11-19 15:19 ` Jan Kara
2009-11-19 18:13 ` Stephen Hemminger
2009-11-20 9:23 ` Jan Kara
2009-11-17 17:46 ` [PATCH 2/2] ext2: add wait flag support to sync_fs Stephen Hemminger
2009-11-19 15:34 ` Jan Kara
2009-11-20 10:36 ` Christoph Hellwig
2009-11-20 17:08 ` Stephen Hemminger [this message]
2009-11-20 21:06 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091120090858.62ae15b3@nehalam \
--to=shemminger@vyatta.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox