From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: tytso@mit.edu
Cc: Curt Wohlgemuth <curtw@google.com>,
ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: Remove blocks from inode prealloc list on failure
Date: Fri, 4 Dec 2009 15:13:25 +0530 [thread overview]
Message-ID: <20091204094325.GA4272@skywalker.linux.vnet.ibm.com> (raw)
In-Reply-To: <20091204011022.GI10985@thunk.org>
On Thu, Dec 03, 2009 at 08:10:22PM -0500, tytso@mit.edu wrote:
> On Tue, Dec 01, 2009 at 10:17:02AM -0800, Curt Wohlgemuth wrote:
> > This fixes a leak of blocks in an inode prealloc list if device failures
> > cause ext4_mb_mark_diskspace_used() to fail.
>
> I was going to say that it didn't make sense for
> ext4_discard_inode_pa() should be its own function, but maybe we need
> function that returns blocks back to the either inode *or* the group
> preallocation list? Otherwise right now it looks like we would also
> be potentially leaking blocks from the group preallocation list in
> case of a device failure?
For group preallocation we update the group prealloc values in
ext4_mb_release_context and we use ac->ac_b_ex.fe_len to find
out the count of blocks allocated. So i guess we are not going
to leak blocks from group prealloc space.
-aneesh
next prev parent reply other threads:[~2009-12-04 9:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 18:17 [PATCH] ext4: Remove blocks from inode prealloc list on failure Curt Wohlgemuth
2009-12-04 1:10 ` tytso
2009-12-04 9:43 ` Aneesh Kumar K.V [this message]
2009-12-04 9:46 ` Aneesh Kumar K.V
2009-12-04 19:14 ` Curt Wohlgemuth
2009-12-09 3:21 ` tytso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091204094325.GA4272@skywalker.linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=curtw@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox