From: tytso@mit.edu
To: Curt Wohlgemuth <curtw@google.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: Remove blocks from inode prealloc list on failure
Date: Tue, 8 Dec 2009 22:21:11 -0500 [thread overview]
Message-ID: <20091209032111.GZ27692@thunk.org> (raw)
In-Reply-To: <6601abe90912041114m37284332pd568e13ed5beee2b@mail.gmail.com>
On Fri, Dec 04, 2009 at 11:14:40AM -0800, Curt Wohlgemuth wrote:
> > Can you name it as discard allocated blocks and add a comment saying why
> > we don't need it for MB_GROUP_PA ? Otherwise
> >
> > Acked-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>
> This fixes a leak of blocks in an inode prealloc list if device failures
> cause ext4_mb_mark_diskspace_used() to fail.
>
> Signed-off-by: Curt Wohlgemuth <curtw@google.com>
Added to the ext4 patch queue, thanks.
- Ted
prev parent reply other threads:[~2009-12-09 3:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 18:17 [PATCH] ext4: Remove blocks from inode prealloc list on failure Curt Wohlgemuth
2009-12-04 1:10 ` tytso
2009-12-04 9:43 ` Aneesh Kumar K.V
2009-12-04 9:46 ` Aneesh Kumar K.V
2009-12-04 19:14 ` Curt Wohlgemuth
2009-12-09 3:21 ` tytso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091209032111.GZ27692@thunk.org \
--to=tytso@mit.edu \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=curtw@google.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox