From: Jan Kara <jack@suse.cz>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext3: fix incorrect block reservation on quota transfer.
Date: Thu, 10 Dec 2009 16:52:45 +0100 [thread overview]
Message-ID: <20091210155245.GD26516@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <1260254781-18041-2-git-send-email-dmonakhov@openvz.org>
> Inside ->setattr() call both ATTR_UID and ATTR_GID may be valid
> This means that we end-up with transering all quotas. Add we have
> to reserve QUOTA_DEL_BLOCKS for all quotas, as we do in case of
> QUOTA_INIT_BLOCKS.
Actually, this is a bug introduced by your previous patch (there used
to be a brace after 2*) ;). I've merged this change into your previous
patch.
Honza
--
Jan Kara <jack@suse.cz>
SuSE CR Labs
next prev parent reply other threads:[~2009-12-10 15:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 6:46 [PATCH] ext3: quota macros cleanup Dmitry Monakhov
2009-12-08 6:46 ` [PATCH] ext3: fix incorrect block reservation on quota transfer Dmitry Monakhov
2009-12-10 15:52 ` Jan Kara [this message]
2009-12-08 23:32 ` [PATCH] ext3: quota macros cleanup Mingming
2009-12-08 23:45 ` Dmitry Monakhov
2009-12-10 15:48 ` Jan Kara
2009-12-10 15:54 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091210155245.GD26516@atrey.karlin.mff.cuni.cz \
--to=jack@suse.cz \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox