public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: tytso@mit.edu
Cc: Jan Kara <jack@suse.cz>, Eric Sandeen <sandeen@redhat.com>,
	ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: Should journaled quota be default for ext4?
Date: Tue, 30 Mar 2010 04:24:47 +0200	[thread overview]
Message-ID: <20100330022447.GF18791@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <20100330021008.GB7628@thunk.org>

> On Tue, Mar 30, 2010 at 03:17:50AM +0200, Jan Kara wrote:
> >   Yes, quota-tools currently use these options as well to detect whether they
> > should run the command on the filesystem or not. The problem is that at least
> > "quotaon -a" needs to know on which filesystem it should run and currently it
> > uses quota mount options to decide. I can change quota tools to just look for
> > quota files but that's not guaranteed to succeed because for unjournaled
> > quotas, quota files could be anywhere - even on a different filesystem - and I
> > really know admins who use such setup.
> 
> Hmm.... so is this something we need to continue to support?  If we
> phase out support for anything other than hidden journal files, that
> implies that these sysadmins would eventually need to ove, right?
  Yes, they will be forced to move. Honestly, I never heard a good technical
reason for this so hopefully it won't be a big pain for them. But sure we have
to provide a long enough period where we only warn about deprecation so that we
can get some decent feedback.

> > And for journaled quotas, file name
> > of the quota file is the one given in the {usr,grp}jquota mount option
> > so without it it's impossible to locate the quota file as well.
> 
> ... and sometimes names other than aquota.user and aquota.group are
> used?
  Sadly yes, although I expect this to be rather rare.

> I was thinking about having e2fsck look for those file names, maybe check the
> format, and then offer to auto-convert them to the new format with hidden
> quota files.  I suppose I could have e2fsck try to look for that information
> in /etc/fstab, but that adds a different layer of complexity (namely, we need
> to be confident we can match up a particular device with an /etc/fstab entry,
> which usually but doesn't always work).
  Alternatively, you could have an option where admin could provide filenames
of quota files for conversion if e2fsck cannot find them on its own. It
wouldn't be automated but it would still provide a reasonable transition
path.

									Honza
-- 
Jan Kara <jack@suse.cz>
SuSE CR Labs

      reply	other threads:[~2010-03-30  2:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-26  4:30 Should journaled quota be default for ext4? Eric Sandeen
2010-03-26 14:26 ` tytso
2010-03-30  1:17   ` Jan Kara
2010-03-30  2:10     ` tytso
2010-03-30  2:24       ` Jan Kara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100330022447.GF18791@atrey.karlin.mff.cuni.cz \
    --to=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox