* Re: linux-next: Tree for Aug 30 (jbd2 + bug.h) [not found] <20110830171605.168f29decb0558fa31e59210@canb.auug.org.au> @ 2011-08-31 20:14 ` Randy Dunlap 2011-09-01 11:43 ` Arnd Bergmann 0 siblings, 1 reply; 3+ messages in thread From: Randy Dunlap @ 2011-08-31 20:14 UTC (permalink / raw) To: Stephen Rothwell, linux-ext4; +Cc: linux-next, LKML, Arnd Bergmann On Tue, 30 Aug 2011 17:16:05 +1000 Stephen Rothwell wrote: > Hi all, [Sorry about the delay. My build machine is being slow. If this is alread fixed, sorry about the noise.] When CONFIG_BUG is not enabled (I see this on x86_64): fs/jbd2/transaction.c: In function 'jbd2_journal_dirty_metadata': fs/jbd2/transaction.c:1176: error: implicit declaration of function '__WARN' asm-generic/bug.h does not provide a version of __WARN() when CONFIG_BUG is not enabled... --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: Tree for Aug 30 (jbd2 + bug.h) 2011-08-31 20:14 ` linux-next: Tree for Aug 30 (jbd2 + bug.h) Randy Dunlap @ 2011-09-01 11:43 ` Arnd Bergmann 2011-09-01 20:30 ` Arnaud Lacombe 0 siblings, 1 reply; 3+ messages in thread From: Arnd Bergmann @ 2011-09-01 11:43 UTC (permalink / raw) To: Randy Dunlap; +Cc: Stephen Rothwell, linux-ext4, linux-next, LKML On Wednesday 31 August 2011, Randy Dunlap wrote: > On Tue, 30 Aug 2011 17:16:05 +1000 Stephen Rothwell wrote: > > > Hi all, > > [Sorry about the delay. My build machine is being slow. > If this is alread fixed, sorry about the noise.] > > > When CONFIG_BUG is not enabled (I see this on x86_64): > > fs/jbd2/transaction.c: In function 'jbd2_journal_dirty_metadata': > fs/jbd2/transaction.c:1176: error: implicit declaration of function '__WARN' > > > asm-generic/bug.h does not provide a version of __WARN() when > CONFIG_BUG is not enabled... > Hmm, my feeling is that we shouldn't do that either, and that jbd2 should be changed. If we want a function that does what __WARN() does today, we should probably make a conscious decision about what we want it to be called and not have it start with "__". Arnd ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: Tree for Aug 30 (jbd2 + bug.h) 2011-09-01 11:43 ` Arnd Bergmann @ 2011-09-01 20:30 ` Arnaud Lacombe 0 siblings, 0 replies; 3+ messages in thread From: Arnaud Lacombe @ 2011-09-01 20:30 UTC (permalink / raw) To: Arnd Bergmann Cc: Randy Dunlap, Stephen Rothwell, linux-ext4, linux-next, LKML Hi, On Thu, Sep 1, 2011 at 7:43 AM, Arnd Bergmann <arnd@arndb.de> wrote: > On Wednesday 31 August 2011, Randy Dunlap wrote: >> On Tue, 30 Aug 2011 17:16:05 +1000 Stephen Rothwell wrote: >> >> > Hi all, >> >> [Sorry about the delay. My build machine is being slow. >> If this is alread fixed, sorry about the noise.] >> >> >> When CONFIG_BUG is not enabled (I see this on x86_64): >> >> fs/jbd2/transaction.c: In function 'jbd2_journal_dirty_metadata': >> fs/jbd2/transaction.c:1176: error: implicit declaration of function '__WARN' >> >> >> asm-generic/bug.h does not provide a version of __WARN() when >> CONFIG_BUG is not enabled... >> > > Hmm, my feeling is that we shouldn't do that either, and that jbd2 should > be changed. If we want a function that does what __WARN() does today, we > should probably make a conscious decision about what we want it to be called > and not have it start with "__". > Why is WARN_ON() not used here ? - Arnaud > Arnd > -- > To unsubscribe from this list: send the line "unsubscribe linux-next" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-01 20:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20110830171605.168f29decb0558fa31e59210@canb.auug.org.au>
2011-08-31 20:14 ` linux-next: Tree for Aug 30 (jbd2 + bug.h) Randy Dunlap
2011-09-01 11:43 ` Arnd Bergmann
2011-09-01 20:30 ` Arnaud Lacombe
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox