* [patch] ext4: using PTR_ERR() on the wrong variable in ext4_ext_migrate()
@ 2012-01-26 6:14 Dan Carpenter
2012-02-13 23:41 ` Ted Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-01-26 6:14 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Andreas Dilger, linux-ext4, kernel-janitors
"inode" is a valid pointer here. "tmp_inode" was intended.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/ext4/migrate.c b/fs/ext4/migrate.c
index e7d6bb0..f39f80f 100644
--- a/fs/ext4/migrate.c
+++ b/fs/ext4/migrate.c
@@ -471,7 +471,7 @@ int ext4_ext_migrate(struct inode *inode)
tmp_inode = ext4_new_inode(handle, inode->i_sb->s_root->d_inode,
S_IFREG, NULL, goal, owner);
if (IS_ERR(tmp_inode)) {
- retval = PTR_ERR(inode);
+ retval = PTR_ERR(tmp_inode);
ext4_journal_stop(handle);
return retval;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] ext4: using PTR_ERR() on the wrong variable in ext4_ext_migrate()
2012-01-26 6:14 [patch] ext4: using PTR_ERR() on the wrong variable in ext4_ext_migrate() Dan Carpenter
@ 2012-02-13 23:41 ` Ted Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Ted Ts'o @ 2012-02-13 23:41 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Andreas Dilger, linux-ext4, kernel-janitors
On Thu, Jan 26, 2012 at 09:14:06AM +0300, Dan Carpenter wrote:
> "inode" is a valid pointer here. "tmp_inode" was intended.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-13 23:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-26 6:14 [patch] ext4: using PTR_ERR() on the wrong variable in ext4_ext_migrate() Dan Carpenter
2012-02-13 23:41 ` Ted Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox