From: Jan Kara <jack@suse.cz>
To: Andrew Perepechko <anserper@ya.ru>
Cc: Jan Kara <jack@suse.cz>, linux-ext4@vger.kernel.org
Subject: Re: dead/wrong code in ext3/4_releasepage()
Date: Mon, 2 Jul 2012 19:33:26 +0200 [thread overview]
Message-ID: <20120702173326.GL6679@quack.suse.cz> (raw)
In-Reply-To: <4FF1D712.3060402@ya.ru>
Hi,
On Mon 02-07-12 21:14:58, Andrew Perepechko wrote:
> So you think the correct fix would be to remove the check completely
> since every try_to_release_page() caller is obliged to perform the
> page_has_private() check?
Yes, I think that would be reasonable. XFS already relies on this so
it should be safe.
Honza
> On 07/02/2012 09:09 PM, Jan Kara wrote:
> >On Fri 29-06-12 20:52:51, Andrew Perepechko wrote:
> >>This does not lead to oom or any similar issue since calls to
> >>try_to_release_page()
> >>are accompanied by page_has_private() checks.
> >>
> >>
> > The check is a dead code because ->release_page() is called only if
> >PagePrivate bit is set.
> >
> > Honza
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2012-07-02 17:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 16:52 dead/wrong code in ext3/4_releasepage() Andrew Perepechko
2012-07-02 17:09 ` Jan Kara
2012-07-02 17:14 ` Andrew Perepechko
2012-07-02 17:33 ` Jan Kara [this message]
2012-07-02 18:17 ` Theodore Ts'o
2012-07-02 18:19 ` Andrew Perepechko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120702173326.GL6679@quack.suse.cz \
--to=jack@suse.cz \
--cc=anserper@ya.ru \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox