* re: ext4: Introduce FALLOC_FL_ZERO_RANGE flag for fallocate
@ 2014-03-28 8:03 Dan Carpenter
2014-03-31 8:41 ` Lukáš Czerner
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-03-28 8:03 UTC (permalink / raw)
To: lczerner; +Cc: linux-ext4
Hello Lukas Czerner,
The patch 1f0e51771281: "ext4: Introduce FALLOC_FL_ZERO_RANGE flag
for fallocate" from Mar 18, 2014, leads to the following static
checker warning:
fs/ext4/extents.c:3653 ext4_split_convert_extents()
warn: odd binop '0x4 & 0x10'
fs/ext4/extents.c
3650 } else if (flags | EXT4_GET_BLOCKS_CONVERT) {
3651 split_flag |= ee_block + ee_len <= eof_block ?
3652 EXT4_EXT_MAY_ZEROOUT : 0;
3653 split_flag |= (EXT4_EXT_MARK_UNINIT2 & EXT4_EXT_DATA_VALID2);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This statement is a no-op. Probably | was intended?
3654 }
3655 flags |= EXT4_GET_BLOCKS_PRE_IO;
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread* re: ext4: Introduce FALLOC_FL_ZERO_RANGE flag for fallocate
2014-03-28 8:03 ext4: Introduce FALLOC_FL_ZERO_RANGE flag for fallocate Dan Carpenter
@ 2014-03-31 8:41 ` Lukáš Czerner
0 siblings, 0 replies; 2+ messages in thread
From: Lukáš Czerner @ 2014-03-31 8:41 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-ext4
On Fri, 28 Mar 2014, Dan Carpenter wrote:
> Date: Fri, 28 Mar 2014 11:03:56 +0300
> From: Dan Carpenter <dan.carpenter@oracle.com>
> To: lczerner@redhat.com
> Cc: linux-ext4@vger.kernel.org
> Subject: re: ext4: Introduce FALLOC_FL_ZERO_RANGE flag for fallocate
>
> Hello Lukas Czerner,
>
> The patch 1f0e51771281: "ext4: Introduce FALLOC_FL_ZERO_RANGE flag
> for fallocate" from Mar 18, 2014, leads to the following static
> checker warning:
>
> fs/ext4/extents.c:3653 ext4_split_convert_extents()
> warn: odd binop '0x4 & 0x10'
>
> fs/ext4/extents.c
> 3650 } else if (flags | EXT4_GET_BLOCKS_CONVERT) {
> 3651 split_flag |= ee_block + ee_len <= eof_block ?
> 3652 EXT4_EXT_MAY_ZEROOUT : 0;
> 3653 split_flag |= (EXT4_EXT_MARK_UNINIT2 & EXT4_EXT_DATA_VALID2);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Right,
thanks.
-Lukas
> This statement is a no-op. Probably | was intended?
>
> 3654 }
> 3655 flags |= EXT4_GET_BLOCKS_PRE_IO;
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-31 8:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-28 8:03 ext4: Introduce FALLOC_FL_ZERO_RANGE flag for fallocate Dan Carpenter
2014-03-31 8:41 ` Lukáš Czerner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox