* [PATCH] fs/ext2/super.c: Drop memory allocation cast
@ 2014-06-10 14:41 Himangi Saraogi
2014-06-11 12:14 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Himangi Saraogi @ 2014-06-10 14:41 UTC (permalink / raw)
To: Jan Kara, linux-ext4, linux-kernel; +Cc: julia.lawall
Drop cast on the result of kmem_cache_alloc.
The semantic patch that makes this change is as follows:
// <smpl>
@@
type T;
@@
- (T *)
(\(kmalloc\|kzalloc\|kcalloc\|kmem_cache_alloc\|kmem_cache_zalloc\|
kmem_cache_alloc_node\|kmalloc_node\|kzalloc_node\)(...))
// </smpl>
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
---
fs/ext2/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 3750031..b88edc0 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -161,7 +161,7 @@ static struct kmem_cache * ext2_inode_cachep;
static struct inode *ext2_alloc_inode(struct super_block *sb)
{
struct ext2_inode_info *ei;
- ei = (struct ext2_inode_info *)kmem_cache_alloc(ext2_inode_cachep, GFP_KERNEL);
+ ei = kmem_cache_alloc(ext2_inode_cachep, GFP_KERNEL);
if (!ei)
return NULL;
ei->i_block_alloc_info = NULL;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] fs/ext2/super.c: Drop memory allocation cast
2014-06-10 14:41 [PATCH] fs/ext2/super.c: Drop memory allocation cast Himangi Saraogi
@ 2014-06-11 12:14 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2014-06-11 12:14 UTC (permalink / raw)
To: Himangi Saraogi; +Cc: Jan Kara, linux-ext4, linux-kernel, julia.lawall
On Tue 10-06-14 20:11:18, Himangi Saraogi wrote:
> Drop cast on the result of kmem_cache_alloc.
>
> The semantic patch that makes this change is as follows:
>
> // <smpl>
> @@
> type T;
> @@
>
> - (T *)
> (\(kmalloc\|kzalloc\|kcalloc\|kmem_cache_alloc\|kmem_cache_zalloc\|
> kmem_cache_alloc_node\|kmalloc_node\|kzalloc_node\)(...))
> // </smpl>
>
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Merged to my tree. Thanks!
Honza
> ---
> fs/ext2/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 3750031..b88edc0 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -161,7 +161,7 @@ static struct kmem_cache * ext2_inode_cachep;
> static struct inode *ext2_alloc_inode(struct super_block *sb)
> {
> struct ext2_inode_info *ei;
> - ei = (struct ext2_inode_info *)kmem_cache_alloc(ext2_inode_cachep, GFP_KERNEL);
> + ei = kmem_cache_alloc(ext2_inode_cachep, GFP_KERNEL);
> if (!ei)
> return NULL;
> ei->i_block_alloc_info = NULL;
> --
> 1.9.1
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-11 12:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-10 14:41 [PATCH] fs/ext2/super.c: Drop memory allocation cast Himangi Saraogi
2014-06-11 12:14 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox