* [RFC] ext4: remove unused page_idx
@ 2015-11-04 8:03 yalin wang
2015-11-05 15:42 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: yalin wang @ 2015-11-04 8:03 UTC (permalink / raw)
To: tytso, adilger.kernel, linux-ext4, linux-kernel; +Cc: yalin wang
Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
---
fs/ext4/readpage.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
ignore my previous patch
diff --git a/fs/ext4/readpage.c b/fs/ext4/readpage.c
index 5dc5e95..2cc2760 100644
--- a/fs/ext4/readpage.c
+++ b/fs/ext4/readpage.c
@@ -135,7 +135,6 @@ int ext4_mpage_readpages(struct address_space *mapping,
unsigned nr_pages)
{
struct bio *bio = NULL;
- unsigned page_idx;
sector_t last_block_in_bio = 0;
struct inode *inode = mapping->host;
@@ -157,7 +156,7 @@ int ext4_mpage_readpages(struct address_space *mapping,
map.m_len = 0;
map.m_flags = 0;
- for (page_idx = 0; nr_pages; page_idx++, nr_pages--) {
+ for (; nr_pages; nr_pages--) {
int fully_mapped = 1;
unsigned first_hole = blocks_per_page;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [RFC] ext4: remove unused page_idx
2015-11-04 8:03 [RFC] ext4: remove unused page_idx yalin wang
@ 2015-11-05 15:42 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2015-11-05 15:42 UTC (permalink / raw)
To: yalin wang; +Cc: tytso, adilger.kernel, linux-ext4, linux-kernel
On Wed 04-11-15 16:03:39, yalin wang wrote:
> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
> ---
> fs/ext4/readpage.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> ignore my previous patch
Ah, ignore my previous review ;) But next time it is good to reply to that
patch that you are withdrawing it to so that people can immediately see it.
This patch look good to me. You can add:
Reviewed-by: Jan Kara <jack@suse.com>
Honza
>
> diff --git a/fs/ext4/readpage.c b/fs/ext4/readpage.c
> index 5dc5e95..2cc2760 100644
> --- a/fs/ext4/readpage.c
> +++ b/fs/ext4/readpage.c
> @@ -135,7 +135,6 @@ int ext4_mpage_readpages(struct address_space *mapping,
> unsigned nr_pages)
> {
> struct bio *bio = NULL;
> - unsigned page_idx;
> sector_t last_block_in_bio = 0;
>
> struct inode *inode = mapping->host;
> @@ -157,7 +156,7 @@ int ext4_mpage_readpages(struct address_space *mapping,
> map.m_len = 0;
> map.m_flags = 0;
>
> - for (page_idx = 0; nr_pages; page_idx++, nr_pages--) {
> + for (; nr_pages; nr_pages--) {
> int fully_mapped = 1;
> unsigned first_hole = blocks_per_page;
>
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-05 15:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-04 8:03 [RFC] ext4: remove unused page_idx yalin wang
2015-11-05 15:42 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox