From: Jan Kara <jack@suse.cz>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: linux-ext4@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
Jan Kara <jack@suse.com>, Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH] ext4: fix off-by-one error when writing back pages before dio read
Date: Tue, 23 May 2017 09:53:05 +0200 [thread overview]
Message-ID: <20170523075305.GA1230@quack2.suse.cz> (raw)
In-Reply-To: <20170523013441.49030-1-ebiggers3@gmail.com>
On Mon 22-05-17 18:34:41, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> The 'lend' argument of filemap_write_and_wait_range() is inclusive, so
> we need to subtract 1 from pos + count.
>
> Note that 'count' is guaranteed to be nonzero since
> ext4_file_read_iter() returns early when given a 0 count.
>
> Fixes: 16c54688592c ("ext4: Allow parallel DIO reads")
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Yeah. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ext4/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 7c6e715b4d2e..3080ea82dd6d 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -3710,7 +3710,7 @@ static ssize_t ext4_direct_IO_read(struct kiocb *iocb, struct iov_iter *iter)
> */
> inode_lock_shared(inode);
> ret = filemap_write_and_wait_range(mapping, iocb->ki_pos,
> - iocb->ki_pos + count);
> + iocb->ki_pos + count - 1);
> if (ret)
> goto out_unlock;
> ret = __blockdev_direct_IO(iocb, inode, inode->i_sb->s_bdev,
> --
> 2.13.0.219.gdb65acc882-goog
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2017-05-23 7:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 1:34 [PATCH] ext4: fix off-by-one error when writing back pages before dio read Eric Biggers
2017-05-23 7:53 ` Jan Kara [this message]
2017-05-24 22:08 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523075305.GA1230@quack2.suse.cz \
--to=jack@suse.cz \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox