From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Eric Biggers <ebiggers3@gmail.com>,
linux-ext4@vger.kernel.org, Jan Kara <jack@suse.com>,
Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH] ext4: fix off-by-one error when writing back pages before dio read
Date: Wed, 24 May 2017 18:08:31 -0400 [thread overview]
Message-ID: <20170524220831.45223qit3uzzlntc@thunk.org> (raw)
In-Reply-To: <20170523075305.GA1230@quack2.suse.cz>
On Tue, May 23, 2017 at 09:53:05AM +0200, Jan Kara wrote:
> On Mon 22-05-17 18:34:41, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > The 'lend' argument of filemap_write_and_wait_range() is inclusive, so
> > we need to subtract 1 from pos + count.
> >
> > Note that 'count' is guaranteed to be nonzero since
> > ext4_file_read_iter() returns early when given a 0 count.
> >
> > Fixes: 16c54688592c ("ext4: Allow parallel DIO reads")
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
>
> Yeah. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Thanks, applied.
- Ted
prev parent reply other threads:[~2017-05-24 22:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 1:34 [PATCH] ext4: fix off-by-one error when writing back pages before dio read Eric Biggers
2017-05-23 7:53 ` Jan Kara
2017-05-24 22:08 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524220831.45223qit3uzzlntc@thunk.org \
--to=tytso@mit.edu \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox