From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Tyson Nottingham <tgnottingham@gmail.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca
Subject: Re: [PATCH] ext4: make huge file flag user visible.
Date: Tue, 23 Jan 2018 21:09:30 -0800 [thread overview]
Message-ID: <20180124050930.GF5594@magnolia> (raw)
In-Reply-To: <20180124050333.GC5594@magnolia>
On Tue, Jan 23, 2018 at 09:03:33PM -0800, Darrick J. Wong wrote:
> On Tue, Jan 23, 2018 at 08:15:48PM -0800, Tyson Nottingham wrote:
> > Make huge file flag visible to clients of FS_IOC_GETFLAGS ioctl, e.g.
> > the userspace tool lsattr, which expects the flag to be visible.
>
> Pardon my asking, but why is this necessary? Are there
> userspace-visible effects of this flag?
Ahh, the chattr man page says that 'h' means HUGE_FILE_FL, but I guess
ext4 won't report it to userspace...?
<shrug> XFS won't either, maybe we just kill the 'h' option? :)
--D
>
> --D
>
> >
> > Signed-off-by: Tyson Nottingham <tgnottingham@gmail.com>
> > ---
> > fs/ext4/ext4.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> > index 3241475..dbd6318 100644
> > --- a/fs/ext4/ext4.h
> > +++ b/fs/ext4/ext4.h
> > @@ -400,7 +400,7 @@ struct flex_groups {
> > #define EXT4_PROJINHERIT_FL 0x20000000 /* Create with parents projid */
> > #define EXT4_RESERVED_FL 0x80000000 /* reserved for ext4 lib */
> >
> > -#define EXT4_FL_USER_VISIBLE 0x304BDFFF /* User visible flags */
> > +#define EXT4_FL_USER_VISIBLE 0x304FDFFF /* User visible flags */
> > #define EXT4_FL_USER_MODIFIABLE 0x204BC0FF /* User modifiable flags */
> >
> > /* Flags we can manipulate with through EXT4_IOC_FSSETXATTR */
> > --
> > 2.7.4
> >
next prev parent reply other threads:[~2018-01-24 5:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 4:15 [PATCH] ext4: make huge file flag user visible Tyson Nottingham
2018-01-24 5:03 ` Darrick J. Wong
2018-01-24 5:09 ` Darrick J. Wong [this message]
2018-01-25 7:48 ` Tyson Nottingham
2018-01-29 23:08 ` Darrick J. Wong
2018-02-05 22:29 ` Tyson Nottingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124050930.GF5594@magnolia \
--to=darrick.wong@oracle.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=tgnottingham@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox