From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Tyson Nottingham <tgnottingham@gmail.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca
Subject: Re: [PATCH] ext4: make huge file flag user visible.
Date: Mon, 29 Jan 2018 15:08:16 -0800 [thread overview]
Message-ID: <20180129230816.GM9359@magnolia> (raw)
In-Reply-To: <20180125074811.GA24022@L-66Y>
On Wed, Jan 24, 2018 at 11:48:14PM -0800, Tyson Nottingham wrote:
> On Tue, Jan 23, 2018 at 09:09:30PM -0800, Darrick J. Wong wrote:
>
> > > Pardon my asking, but why is this necessary? Are there
> > > userspace-visible effects of this flag?
> >
> > Ahh, the chattr man page says that 'h' means HUGE_FILE_FL, but I guess
> > ext4 won't report it to userspace...?
> >
> > <shrug> XFS won't either, maybe we just kill the 'h' option? :)
>
> Thanks for responses. Yes, I was just trying to make ext4 consistent with the
> man page. Since apparently the flag was intended to be user visible at some
> point, I thought it would be fine to make it so. As you said, removing it from
> chattr/lsattr is another option. I'll do whatever I'm told. :)
Ted hasn't replied in a couple of days, but I would surmise from digging
in the ext4 code that we've never exposed the huge file flag to
userspace, so it'd probably be better to withdraw the documentation/code
of the 'h' option from the chattr manpage instead. ext2/ext3 never had
such a flag at all, so it's unlikely to break anything.
--D
> Tyson
next prev parent reply other threads:[~2018-01-29 23:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 4:15 [PATCH] ext4: make huge file flag user visible Tyson Nottingham
2018-01-24 5:03 ` Darrick J. Wong
2018-01-24 5:09 ` Darrick J. Wong
2018-01-25 7:48 ` Tyson Nottingham
2018-01-29 23:08 ` Darrick J. Wong [this message]
2018-02-05 22:29 ` Tyson Nottingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180129230816.GM9359@magnolia \
--to=darrick.wong@oracle.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=tgnottingham@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox