* [PATCH] ext4: remove QUOTA flag setting in set_qf_name()
@ 2018-10-08 23:50 Chengguang Xu
2018-10-09 1:50 ` Theodore Y. Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Chengguang Xu @ 2018-10-08 23:50 UTC (permalink / raw)
To: tytso, adilger.kernel; +Cc: linux-ext4, Chengguang Xu
Mount flag QUOTA is the same as flag USRQUOTA in ext4, so should
not set flag QUOTA in set_qf_name().
Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
---
fs/ext4/super.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 1145109968ef..9ed33e4860db 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1566,7 +1566,6 @@ static int set_qf_name(struct super_block *sb, int qtype, substring_t *args)
goto errout;
}
sbi->s_qf_names[qtype] = qname;
- set_opt(sb, QUOTA);
return 1;
errout:
kfree(qname);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: remove QUOTA flag setting in set_qf_name()
2018-10-08 23:50 [PATCH] ext4: remove QUOTA flag setting in set_qf_name() Chengguang Xu
@ 2018-10-09 1:50 ` Theodore Y. Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Y. Ts'o @ 2018-10-09 1:50 UTC (permalink / raw)
To: Chengguang Xu; +Cc: adilger.kernel, linux-ext4
On Tue, Oct 09, 2018 at 07:50:13AM +0800, Chengguang Xu wrote:
> Mount flag QUOTA is the same as flag USRQUOTA in ext4, so should
> not set flag QUOTA in set_qf_name().
>
> Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
> ---
> fs/ext4/super.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 1145109968ef..9ed33e4860db 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1566,7 +1566,6 @@ static int set_qf_name(struct super_block *sb, int qtype, substring_t *args)
> goto errout;
> }
> sbi->s_qf_names[qtype] = qname;
> - set_opt(sb, QUOTA);
No, sorry. This is still needed so that the usrjquota and the
grpjquota mount options will work correctly. And it's not like
set_qf_name() is a performance hot path.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-09 9:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-08 23:50 [PATCH] ext4: remove QUOTA flag setting in set_qf_name() Chengguang Xu
2018-10-09 1:50 ` Theodore Y. Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox