* [PATCH] e2fsprogs: Fix autoheader failure
@ 2019-03-29 16:58 Jan Kara
2019-03-30 1:48 ` Theodore Ts'o
0 siblings, 1 reply; 6+ messages in thread
From: Jan Kara @ 2019-03-29 16:58 UTC (permalink / raw)
To: Ted Tso; +Cc: linux-ext4, Jan Kara
Autoheader reports:
autoheader: warning: missing template: HAVE_BLKID_PROBE_ENABLE_PARTITIONS
autoheader: Use AC_DEFINE([HAVE_BLKID_PROBE_ENABLE_PARTITIONS], [], [Description])
autoheader: warning: missing template: HAVE_BLKID_PROBE_GET_TOPOLOGY
so provide appropriate descriptions for the defines.
Signed-off-by: Jan Kara <jack@suse.cz>
---
configure.ac | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 248b291dd0d2..290f93ebdf2f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1119,9 +1119,9 @@ dnl the functions added after migrating that library to util-linux
dnl
if test -n "$BLKID_CMT"; then
AC_CHECK_LIB(blkid, blkid_probe_get_topology,
- AC_DEFINE(HAVE_BLKID_PROBE_GET_TOPOLOGY, 1))
+ AC_DEFINE(HAVE_BLKID_PROBE_GET_TOPOLOGY, 1, [Define to 1 if blkid library provides blkid_probe_get_topology]))
AC_CHECK_LIB(blkid, blkid_probe_enable_partitions,
- AC_DEFINE(HAVE_BLKID_PROBE_ENABLE_PARTITIONS, 1))
+ AC_DEFINE(HAVE_BLKID_PROBE_ENABLE_PARTITIONS, 1, [Define to 1 if blkid library provides blkid_probe_enable_partitions]))
fi
dnl
if test -n "$DLOPEN_LIB" ; then
--
2.16.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] e2fsprogs: Fix autoheader failure
2019-03-29 16:58 [PATCH] e2fsprogs: Fix autoheader failure Jan Kara
@ 2019-03-30 1:48 ` Theodore Ts'o
2019-04-01 8:05 ` Jan Kara
0 siblings, 1 reply; 6+ messages in thread
From: Theodore Ts'o @ 2019-03-30 1:48 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-ext4
On Fri, Mar 29, 2019 at 05:58:03PM +0100, Jan Kara wrote:
> Autoheader reports:
>
> autoheader: warning: missing template: HAVE_BLKID_PROBE_ENABLE_PARTITIONS
> autoheader: Use AC_DEFINE([HAVE_BLKID_PROBE_ENABLE_PARTITIONS], [], [Description])
> autoheader: warning: missing template: HAVE_BLKID_PROBE_GET_TOPOLOGY
>
> so provide appropriate descriptions for the defines.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
Thanks, apologies for failing to push out the e2fsprogs fix out to git
earlier, but this problem has already been fixed by commit
f72ea2deb0d8.
Cheers,
- Ted
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] e2fsprogs: Fix autoheader failure
2019-03-30 1:48 ` Theodore Ts'o
@ 2019-04-01 8:05 ` Jan Kara
2019-04-01 13:24 ` Theodore Ts'o
0 siblings, 1 reply; 6+ messages in thread
From: Jan Kara @ 2019-04-01 8:05 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Jan Kara, linux-ext4
On Fri 29-03-19 21:48:57, Theodore Ts'o wrote:
> On Fri, Mar 29, 2019 at 05:58:03PM +0100, Jan Kara wrote:
> > Autoheader reports:
> >
> > autoheader: warning: missing template: HAVE_BLKID_PROBE_ENABLE_PARTITIONS
> > autoheader: Use AC_DEFINE([HAVE_BLKID_PROBE_ENABLE_PARTITIONS], [], [Description])
> > autoheader: warning: missing template: HAVE_BLKID_PROBE_GET_TOPOLOGY
> >
> > so provide appropriate descriptions for the defines.
> >
> > Signed-off-by: Jan Kara <jack@suse.cz>
>
> Thanks, apologies for failing to push out the e2fsprogs fix out to git
> earlier, but this problem has already been fixed by commit
> f72ea2deb0d8.
No problem :). I was just packaging latest e2fsprogs release and stumbled
upon this...
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] e2fsprogs: Fix autoheader failure
2019-04-01 8:05 ` Jan Kara
@ 2019-04-01 13:24 ` Theodore Ts'o
2019-04-01 14:38 ` Jan Kara
0 siblings, 1 reply; 6+ messages in thread
From: Theodore Ts'o @ 2019-04-01 13:24 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-ext4
On Mon, Apr 01, 2019 at 10:05:48AM +0200, Jan Kara wrote:
>
> No problem :). I was just packaging latest e2fsprogs release and stumbled
> upon this...
If you are packaging the e2fsprogs v1.45, I suggest you either (a)
hold back on packaging e2scrub, or (b) wait for 1.45.1, which I hope
to get out fairly soon, since by packaing 1.45 for Debian unstable,
we've gotten many useful bug reports and as you can see, there are a
lot of e2scrub fixes that are queued up for the next release.
- Ted
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] e2fsprogs: Fix autoheader failure
2019-04-01 13:24 ` Theodore Ts'o
@ 2019-04-01 14:38 ` Jan Kara
2019-04-01 15:13 ` Lukas Czerner
0 siblings, 1 reply; 6+ messages in thread
From: Jan Kara @ 2019-04-01 14:38 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Jan Kara, linux-ext4
On Mon 01-04-19 09:24:12, Theodore Ts'o wrote:
> On Mon, Apr 01, 2019 at 10:05:48AM +0200, Jan Kara wrote:
> >
> > No problem :). I was just packaging latest e2fsprogs release and stumbled
> > upon this...
>
> If you are packaging the e2fsprogs v1.45, I suggest you either (a)
> hold back on packaging e2scrub, or (b) wait for 1.45.1, which I hope
> to get out fairly soon, since by packaing 1.45 for Debian unstable,
> we've gotten many useful bug reports and as you can see, there are a
> lot of e2scrub fixes that are queued up for the next release.
Thanks for info! I did package e2scrub but so far disabled installing any
of crond files, systemd files, or udev rules so it should be harmless
unless someone manually runs it...
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] e2fsprogs: Fix autoheader failure
2019-04-01 14:38 ` Jan Kara
@ 2019-04-01 15:13 ` Lukas Czerner
0 siblings, 0 replies; 6+ messages in thread
From: Lukas Czerner @ 2019-04-01 15:13 UTC (permalink / raw)
To: Jan Kara; +Cc: Theodore Ts'o, linux-ext4
On Mon, Apr 01, 2019 at 04:38:59PM +0200, Jan Kara wrote:
> On Mon 01-04-19 09:24:12, Theodore Ts'o wrote:
> > On Mon, Apr 01, 2019 at 10:05:48AM +0200, Jan Kara wrote:
> > >
> > > No problem :). I was just packaging latest e2fsprogs release and stumbled
> > > upon this...
> >
> > If you are packaging the e2fsprogs v1.45, I suggest you either (a)
> > hold back on packaging e2scrub, or (b) wait for 1.45.1, which I hope
> > to get out fairly soon, since by packaing 1.45 for Debian unstable,
> > we've gotten many useful bug reports and as you can see, there are a
> > lot of e2scrub fixes that are queued up for the next release.
>
> Thanks for info! I did package e2scrub but so far disabled installing any
> of crond files, systemd files, or udev rules so it should be harmless
> unless someone manually runs it...
I did pretty much the same thing for rawhide and I do plan to enable the
whole thing with the next update.
Thanks!
-Lukas
>
> Honza
>
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-01 15:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-29 16:58 [PATCH] e2fsprogs: Fix autoheader failure Jan Kara
2019-03-30 1:48 ` Theodore Ts'o
2019-04-01 8:05 ` Jan Kara
2019-04-01 13:24 ` Theodore Ts'o
2019-04-01 14:38 ` Jan Kara
2019-04-01 15:13 ` Lukas Czerner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox