* [PATCH] ext4: make kobj_type structures constant
@ 2023-02-09 3:18 Thomas Weißschuh
2023-02-17 15:39 ` Jan Kara
2023-03-08 4:33 ` Theodore Ts'o
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Weißschuh @ 2023-02-09 3:18 UTC (permalink / raw)
To: Theodore Ts'o, Andreas Dilger
Cc: linux-ext4, linux-kernel, Thomas Weißschuh
Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
the driver core allows the usage of const struct kobj_type.
Take advantage of this to constify the structure definitions to prevent
modification at runtime.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
fs/ext4/sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/sysfs.c b/fs/ext4/sysfs.c
index d233c24ea342..364e3da49b03 100644
--- a/fs/ext4/sysfs.c
+++ b/fs/ext4/sysfs.c
@@ -496,13 +496,13 @@ static const struct sysfs_ops ext4_attr_ops = {
.store = ext4_attr_store,
};
-static struct kobj_type ext4_sb_ktype = {
+static const struct kobj_type ext4_sb_ktype = {
.default_groups = ext4_groups,
.sysfs_ops = &ext4_attr_ops,
.release = ext4_sb_release,
};
-static struct kobj_type ext4_feat_ktype = {
+static const struct kobj_type ext4_feat_ktype = {
.default_groups = ext4_feat_groups,
.sysfs_ops = &ext4_attr_ops,
.release = (void (*)(struct kobject *))kfree,
---
base-commit: 0983f6bf2bfc0789b51ddf7315f644ff4da50acb
change-id: 20230209-kobj_type-ext4-962d5425769a
Best regards,
--
Thomas Weißschuh <linux@weissschuh.net>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ext4: make kobj_type structures constant
2023-02-09 3:18 [PATCH] ext4: make kobj_type structures constant Thomas Weißschuh
@ 2023-02-17 15:39 ` Jan Kara
2023-03-08 4:33 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Jan Kara @ 2023-02-17 15:39 UTC (permalink / raw)
To: Thomas Weißschuh
Cc: Theodore Ts'o, Andreas Dilger, linux-ext4, linux-kernel
On Thu 09-02-23 03:18:35, Thomas Weißschuh wrote:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definitions to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ext4/sysfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext4/sysfs.c b/fs/ext4/sysfs.c
> index d233c24ea342..364e3da49b03 100644
> --- a/fs/ext4/sysfs.c
> +++ b/fs/ext4/sysfs.c
> @@ -496,13 +496,13 @@ static const struct sysfs_ops ext4_attr_ops = {
> .store = ext4_attr_store,
> };
>
> -static struct kobj_type ext4_sb_ktype = {
> +static const struct kobj_type ext4_sb_ktype = {
> .default_groups = ext4_groups,
> .sysfs_ops = &ext4_attr_ops,
> .release = ext4_sb_release,
> };
>
> -static struct kobj_type ext4_feat_ktype = {
> +static const struct kobj_type ext4_feat_ktype = {
> .default_groups = ext4_feat_groups,
> .sysfs_ops = &ext4_attr_ops,
> .release = (void (*)(struct kobject *))kfree,
>
> ---
> base-commit: 0983f6bf2bfc0789b51ddf7315f644ff4da50acb
> change-id: 20230209-kobj_type-ext4-962d5425769a
>
> Best regards,
> --
> Thomas Weißschuh <linux@weissschuh.net>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ext4: make kobj_type structures constant
2023-02-09 3:18 [PATCH] ext4: make kobj_type structures constant Thomas Weißschuh
2023-02-17 15:39 ` Jan Kara
@ 2023-03-08 4:33 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2023-03-08 4:33 UTC (permalink / raw)
To: Andreas Dilger, Thomas Weißschuh
Cc: Theodore Ts'o, linux-kernel, linux-ext4
On Thu, 09 Feb 2023 03:18:35 +0000, Thomas Weißschuh wrote:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definitions to prevent
> modification at runtime.
>
>
> [...]
Applied, thanks!
[1/1] ext4: make kobj_type structures constant
commit: 60db00e0a1490adcdc8b80887f7caf954d8bcd3e
Best regards,
--
Theodore Ts'o <tytso@mit.edu>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-08 4:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-09 3:18 [PATCH] ext4: make kobj_type structures constant Thomas Weißschuh
2023-02-17 15:39 ` Jan Kara
2023-03-08 4:33 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox