From: Jan Kara <jack@suse.cz>
To: Bean Huo <beanhuo@iokpp.de>
Cc: viro@zeniv.linux.org.uk, brauner@kernel.org,
akpm@linux-foundation.org, jack@suse.cz, jack@suse.com,
tytso@mit.edu, adilger.kernel@dilger.ca, mark@fasheh.com,
jlbec@evilplan.org, joseph.qi@linux.alibaba.com,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com,
beanhuo@micron.com
Subject: Re: [PATCH v1 4/5] fs/ocfs2: No need to check return value of block_commit_write()
Date: Mon, 19 Jun 2023 11:56:29 +0200 [thread overview]
Message-ID: <20230619095629.qicy2guryvryc7el@quack3> (raw)
In-Reply-To: <20230618213250.694110-5-beanhuo@iokpp.de>
On Sun 18-06-23 23:32:49, Bean Huo wrote:
> From: Bean Huo <beanhuo@micron.com>
>
> Remove unnecessary check on the return value of block_commit_write().
>
> Signed-off-by: Bean Huo <beanhuo@micron.com>
Looks good to me. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ocfs2/file.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
> index efb09de4343d..39d8dbb26bb3 100644
> --- a/fs/ocfs2/file.c
> +++ b/fs/ocfs2/file.c
> @@ -808,12 +808,7 @@ static int ocfs2_write_zero_page(struct inode *inode, u64 abs_from,
>
>
> /* must not update i_size! */
> - ret = block_commit_write(page, block_start + 1,
> - block_start + 1);
> - if (ret < 0)
> - mlog_errno(ret);
> - else
> - ret = 0;
> + block_commit_write(page, block_start + 1, block_start + 1);
> }
>
> /*
> --
> 2.34.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2023-06-19 9:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-18 21:32 [PATCH v1 0/5] clean up block_commit_write Bean Huo
2023-06-18 21:32 ` [PATCH v1 1/5] fs/buffer: " Bean Huo
2023-06-19 9:52 ` Jan Kara
2023-06-18 21:32 ` [PATCH v1 2/5] fs/buffer.c: convert block_commit_write to return void Bean Huo
2023-06-18 23:35 ` kernel test robot
2023-06-19 9:56 ` Jan Kara
2023-06-19 10:42 ` Bean Huo
2023-06-18 21:32 ` [PATCH v1 3/5] ext4: No need to check return value of block_commit_write() Bean Huo
2023-06-19 9:56 ` Jan Kara
2023-06-18 21:32 ` [PATCH v1 4/5] fs/ocfs2: " Bean Huo
2023-06-19 9:56 ` Jan Kara [this message]
2023-06-18 21:32 ` [PATCH v1 5/5] udf: " Bean Huo
2023-06-19 9:56 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230619095629.qicy2guryvryc7el@quack3 \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=beanhuo@iokpp.de \
--cc=beanhuo@micron.com \
--cc=brauner@kernel.org \
--cc=jack@suse.com \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox