From: Jan Kara <jack@suse.cz>
To: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.com,
dennis.lamerice@gmail.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 3/3] ext4: remove unneeded forward declaration
Date: Wed, 18 Dec 2024 12:37:08 +0100 [thread overview]
Message-ID: <20241218113708.t3cpe3a7b3tmkkni@quack3> (raw)
In-Reply-To: <20241217120356.1399443-4-shikemeng@huaweicloud.com>
On Tue 17-12-24 20:03:56, Kemeng Shi wrote:
> Remove unneeded forward declaration of ext4_destroy_lazyinit_thread().
>
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ext4/super.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 8dfda41dabaa..d294cd43d3f2 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -79,7 +79,6 @@ static int ext4_unfreeze(struct super_block *sb);
> static int ext4_freeze(struct super_block *sb);
> static inline int ext2_feature_set_ok(struct super_block *sb);
> static inline int ext3_feature_set_ok(struct super_block *sb);
> -static void ext4_destroy_lazyinit_thread(void);
> static void ext4_unregister_li_request(struct super_block *sb);
> static void ext4_clear_request_list(void);
> static struct inode *ext4_get_journal_inode(struct super_block *sb,
> --
> 2.30.0
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2024-12-18 11:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 12:03 [PATCH 0/3] Minor cleanups to ext4 and jbd2 Kemeng Shi
2024-12-17 12:03 ` [PATCH 1/3] ext4: remove unused ext4 journal callback Kemeng Shi
2024-12-18 3:40 ` Zhang Yi
2024-12-18 11:35 ` Jan Kara
2024-12-17 12:03 ` [PATCH 2/3] jbd2: remove unused transaction->t_private_list Kemeng Shi
2024-12-17 18:02 ` Matthew Wilcox
2024-12-18 3:26 ` Kemeng Shi
2024-12-18 11:36 ` Jan Kara
2024-12-17 12:03 ` [PATCH 3/3] ext4: remove unneeded forward declaration Kemeng Shi
2024-12-18 3:43 ` Zhang Yi
2024-12-18 11:37 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241218113708.t3cpe3a7b3tmkkni@quack3 \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=dennis.lamerice@gmail.com \
--cc=jack@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shikemeng@huaweicloud.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox