public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.com,
	dennis.lamerice@gmail.com, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/3] jbd2: remove unused transaction->t_private_list
Date: Tue, 17 Dec 2024 18:02:34 +0000	[thread overview]
Message-ID: <Z2G8ujYUUDGSpbGl@casper.infradead.org> (raw)
In-Reply-To: <20241217120356.1399443-3-shikemeng@huaweicloud.com>

On Tue, Dec 17, 2024 at 08:03:55PM +0800, Kemeng Shi wrote:
> +++ b/Documentation/filesystems/journalling.rst
> @@ -112,8 +112,6 @@ so that you can do some of your own management. You ask the journalling
>  layer for calling the callback by simply setting
>  ``journal->j_commit_callback`` function pointer and that function is
>  called after each transaction commit. You can also use
> -``transaction->t_private_list`` for attaching entries to a transaction
> -that need processing when the transaction commits.

I think this also needs:

-called after each transaction commit. You can also use
+called after each transaction commit.


  reply	other threads:[~2024-12-17 18:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-17 12:03 [PATCH 0/3] Minor cleanups to ext4 and jbd2 Kemeng Shi
2024-12-17 12:03 ` [PATCH 1/3] ext4: remove unused ext4 journal callback Kemeng Shi
2024-12-18  3:40   ` Zhang Yi
2024-12-18 11:35   ` Jan Kara
2024-12-17 12:03 ` [PATCH 2/3] jbd2: remove unused transaction->t_private_list Kemeng Shi
2024-12-17 18:02   ` Matthew Wilcox [this message]
2024-12-18  3:26     ` Kemeng Shi
2024-12-18 11:36   ` Jan Kara
2024-12-17 12:03 ` [PATCH 3/3] ext4: remove unneeded forward declaration Kemeng Shi
2024-12-18  3:43   ` Zhang Yi
2024-12-18 11:37   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z2G8ujYUUDGSpbGl@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=adilger.kernel@dilger.ca \
    --cc=dennis.lamerice@gmail.com \
    --cc=jack@suse.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shikemeng@huaweicloud.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox