From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Zorro Lang <zlang@kernel.org>,
Brian Foster <bfoster@redhat.com>,
fstests@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/3] common: remove the $FSYP check in _cleanup_dump
Date: Wed, 29 Jan 2025 06:27:31 +0100 [thread overview]
Message-ID: <20250129052731.GB28665@lst.de> (raw)
In-Reply-To: <20250128191442.GP3557695@frogsfrogsfrogs>
On Tue, Jan 28, 2025 at 11:14:42AM -0800, Darrick J. Wong wrote:
> I went looking in common/dump and I noticed the lack of an explicit
> setup routine. Instead, variables and _require calls are done when
> sourcing the file. Curiously there's no check for FSTYP==xfs, which I
> guess is reasonable for sourced stuff, but I think that should all get
> pulled up into _init_dump() or something.
>
> The other thing I noticed is that sourcing common/dump deletes
> $seqres.full, which seems like a real bug.
Yeah, dump testing is at least as messy as xfsdump itself :)
Btw, did someone every spend some time analyzing why xfs/059 xfs/060
fail relatively frequently when using RT devices? This is one of the
thing on my TODO list when I find a little more time..
next prev parent reply other threads:[~2025-01-29 5:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 7:12 remove _supported_fs v2 Christoph Hellwig
2025-01-28 7:12 ` [PATCH 1/3] generic/363: remove _supported_fs xfs Christoph Hellwig
2025-01-28 19:17 ` Darrick J. Wong
2025-01-29 5:26 ` Christoph Hellwig
2025-01-28 7:12 ` [PATCH 2/3] common: remove the $FSYP check in _cleanup_dump Christoph Hellwig
2025-01-28 19:14 ` Darrick J. Wong
2025-01-29 5:27 ` Christoph Hellwig [this message]
2025-01-28 7:13 ` [PATCH 3/3] replace _supported_fs with _exclude_fs Christoph Hellwig
2025-01-28 19:19 ` Darrick J. Wong
2025-01-29 5:28 ` Christoph Hellwig
2025-02-02 13:31 ` Zorro Lang
2025-02-03 6:40 ` Christoph Hellwig
2025-02-04 17:36 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250129052731.GB28665@lst.de \
--to=hch@lst.de \
--cc=bfoster@redhat.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox