From: Christoph Hellwig <hch@lst.de>
To: Zorro Lang <zlang@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Zorro Lang <zlang@kernel.org>,
Brian Foster <bfoster@redhat.com>,
fstests@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 3/3] replace _supported_fs with _exclude_fs
Date: Mon, 3 Feb 2025 07:40:29 +0100 [thread overview]
Message-ID: <20250203064029.GA16864@lst.de> (raw)
In-Reply-To: <20250202133101.bpst6rzhjn7g4zvw@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>
On Sun, Feb 02, 2025 at 09:31:01PM +0800, Zorro Lang wrote:
> generic/730 is missed:
>
> /var/lib/xfstests/tests/generic/370: line 31: _supported_fs: command not found
>
> Anyway, I'll help to change g/370 when I merge this patch.
generic/730 didn't exist when I submitted this series, you applied
it in the same batch of patches.
But it really should not skip xfs to start with. Either the test
is correct and XFS should fail it (and get fixed) or the test is
incorrect and it should not be added. I suspect it is the former
and I'll look into fixing it.
As added in the comments in this series we should never add a
_exclude_fs without a very good reason and comment explaining it.
next prev parent reply other threads:[~2025-02-03 6:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 7:12 remove _supported_fs v2 Christoph Hellwig
2025-01-28 7:12 ` [PATCH 1/3] generic/363: remove _supported_fs xfs Christoph Hellwig
2025-01-28 19:17 ` Darrick J. Wong
2025-01-29 5:26 ` Christoph Hellwig
2025-01-28 7:12 ` [PATCH 2/3] common: remove the $FSYP check in _cleanup_dump Christoph Hellwig
2025-01-28 19:14 ` Darrick J. Wong
2025-01-29 5:27 ` Christoph Hellwig
2025-01-28 7:13 ` [PATCH 3/3] replace _supported_fs with _exclude_fs Christoph Hellwig
2025-01-28 19:19 ` Darrick J. Wong
2025-01-29 5:28 ` Christoph Hellwig
2025-02-02 13:31 ` Zorro Lang
2025-02-03 6:40 ` Christoph Hellwig [this message]
2025-02-04 17:36 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250203064029.GA16864@lst.de \
--to=hch@lst.de \
--cc=bfoster@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=zlang@kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox