public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Ethan Carter Edwards <ethan@ethancedwards.com>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	oe-kbuild-all@lists.linux.dev, linux-ext4@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2] ext4: replace strcpy() with '.' assignment
Date: Mon, 19 May 2025 09:56:32 -0400	[thread overview]
Message-ID: <20250519135632.GA38098@mit.edu> (raw)
In-Reply-To: <202505191316.JJMnPobO-lkp@intel.com>

On Mon, May 19, 2025 at 01:58:02PM +0800, kernel test robot wrote:
> Hi Ethan,
> 
> kernel test robot noticed the following build errors:

Hi Ethan,

I would really appreciate it if you would at least do a build test
before sending out a patch.  In addition, it would also be helpful if
you ran a smoke test, using "kvm-xfstests smoke".  The instructions
for how to use kvm-xfstests can be found here[1], and it was designed
to be as easy as possible for people who are sending "drive-by
patches".

[1] https://github.com/tytso/xfstests-bld/blob/master/Documentation/kvm-quickstart.md

Running the smoketest only takes about 20 minutes; although if you
want to run more sophistcated testing there is also "kvm-xfstests -c
ext4/4k -g quick", or "kvm-xfstests -c ext4/4k -g auto", or if you
have a 24 hours to kill, there's always "kvm-xfststs full".  (Although
these days I generally use gce-xfstests[2] since this can shard the test
runs across multiple VM's, so it only takes 2.5 hours of wall clock
time.)

[2] https://thunk.org/gce-xfstests

Cheers,

					- TEd

  reply	other threads:[~2025-05-19 13:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-19  3:54 [PATCH v2] ext4: replace strcpy() with '.' assignment Ethan Carter Edwards
2025-05-19  5:58 ` kernel test robot
2025-05-19 13:56   ` Theodore Ts'o [this message]
2025-05-19  5:58 ` kernel test robot
2025-05-19 13:52 ` Kees Cook
2025-05-19 14:59   ` Theodore Ts'o
2025-05-23 12:31     ` David Laight
2025-05-23 14:24       ` Theodore Ts'o
2025-05-23 17:14         ` Kees Cook
2025-05-23 22:07           ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250519135632.GA38098@mit.edu \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=ethan@ethancedwards.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox