Re: [PATCH] e2scrub: honor fstrim setting in e2scrub.conf

["Darrick J. Wong" <djwong@kernel.org>]

On Sat, Jun 28, 2025 at 12:14:15AM -0500, Samuel Smith wrote:
> The systemd service unconditionally passes -t to e2scrub, forcing
> fstrim to run after every scrub regardless of the fstrim setting
> in /etc/e2scrub.conf. Removing the hardcoded flag will allow users to
> control the behavior via the configuration file.
> 
> Signed-off-by: Samuel Smith <satlug@net153.net>

Now that there's a config file, we can indeed drop the explicit -t.

Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  scrub/e2scrub@.service.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scrub/e2scrub@.service.in b/scrub/e2scrub@.service.in
> index 6425263c..3c9893c5 100644
> --- a/scrub/e2scrub@.service.in
> +++ b/scrub/e2scrub@.service.in
> @@ -16,5 +16,5 @@ User=root
>  IOSchedulingClass=idle
>  CPUSchedulingPolicy=idle
>  Environment=SERVICE_MODE=1
> -ExecStart=@root_sbindir@/e2scrub -t %f
> +ExecStart=@root_sbindir@/e2scrub %f
>  SyslogIdentifier=%N
> -- 
> 2.39.5
> 
>