* [PATCH] e2scrub: honor fstrim setting in e2scrub.conf
@ 2025-06-28 5:14 Samuel Smith
2025-06-30 15:19 ` Darrick J. Wong
2025-07-02 2:00 ` Theodore Ts'o
0 siblings, 2 replies; 3+ messages in thread
From: Samuel Smith @ 2025-06-28 5:14 UTC (permalink / raw)
To: linux-ext4
The systemd service unconditionally passes -t to e2scrub, forcing
fstrim to run after every scrub regardless of the fstrim setting
in /etc/e2scrub.conf. Removing the hardcoded flag will allow users to
control the behavior via the configuration file.
Signed-off-by: Samuel Smith <satlug@net153.net>
---
scrub/e2scrub@.service.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scrub/e2scrub@.service.in b/scrub/e2scrub@.service.in
index 6425263c..3c9893c5 100644
--- a/scrub/e2scrub@.service.in
+++ b/scrub/e2scrub@.service.in
@@ -16,5 +16,5 @@ User=root
IOSchedulingClass=idle
CPUSchedulingPolicy=idle
Environment=SERVICE_MODE=1
-ExecStart=@root_sbindir@/e2scrub -t %f
+ExecStart=@root_sbindir@/e2scrub %f
SyslogIdentifier=%N
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] e2scrub: honor fstrim setting in e2scrub.conf
2025-06-28 5:14 [PATCH] e2scrub: honor fstrim setting in e2scrub.conf Samuel Smith
@ 2025-06-30 15:19 ` Darrick J. Wong
2025-07-02 2:00 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2025-06-30 15:19 UTC (permalink / raw)
To: Samuel Smith; +Cc: linux-ext4
On Sat, Jun 28, 2025 at 12:14:15AM -0500, Samuel Smith wrote:
> The systemd service unconditionally passes -t to e2scrub, forcing
> fstrim to run after every scrub regardless of the fstrim setting
> in /etc/e2scrub.conf. Removing the hardcoded flag will allow users to
> control the behavior via the configuration file.
>
> Signed-off-by: Samuel Smith <satlug@net153.net>
Now that there's a config file, we can indeed drop the explicit -t.
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> scrub/e2scrub@.service.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scrub/e2scrub@.service.in b/scrub/e2scrub@.service.in
> index 6425263c..3c9893c5 100644
> --- a/scrub/e2scrub@.service.in
> +++ b/scrub/e2scrub@.service.in
> @@ -16,5 +16,5 @@ User=root
> IOSchedulingClass=idle
> CPUSchedulingPolicy=idle
> Environment=SERVICE_MODE=1
> -ExecStart=@root_sbindir@/e2scrub -t %f
> +ExecStart=@root_sbindir@/e2scrub %f
> SyslogIdentifier=%N
> --
> 2.39.5
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] e2scrub: honor fstrim setting in e2scrub.conf
2025-06-28 5:14 [PATCH] e2scrub: honor fstrim setting in e2scrub.conf Samuel Smith
2025-06-30 15:19 ` Darrick J. Wong
@ 2025-07-02 2:00 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2025-07-02 2:00 UTC (permalink / raw)
To: linux-ext4, Samuel Smith; +Cc: Theodore Ts'o
On Sat, 28 Jun 2025 00:14:15 -0500, Samuel Smith wrote:
> The systemd service unconditionally passes -t to e2scrub, forcing
> fstrim to run after every scrub regardless of the fstrim setting
> in /etc/e2scrub.conf. Removing the hardcoded flag will allow users to
> control the behavior via the configuration file.
>
>
Applied, thanks!
[1/1] e2scrub: honor fstrim setting in e2scrub.conf
commit: 1b11e079a6189a49d7a13c01c13d222c8537cc1e
Best regards,
--
Theodore Ts'o <tytso@mit.edu>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-02 2:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-28 5:14 [PATCH] e2scrub: honor fstrim setting in e2scrub.conf Samuel Smith
2025-06-30 15:19 ` Darrick J. Wong
2025-07-02 2:00 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox