* [PATCH] ext4: clear i_state_flags when alloc inode
@ 2025-11-04 8:12 Haibo Chen
2025-11-04 12:13 ` Jan Kara
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Haibo Chen @ 2025-11-04 8:12 UTC (permalink / raw)
To: Theodore Ts'o, Andreas Dilger, Zhang Yi, Jan Kara
Cc: linux-ext4, linux-kernel, imx, Haibo Chen
i_state_flags used on 32-bit archs, need to clear this flag when
alloc inode.
Find this issue when umount ext4, sometimes track the inode as orphan
accidently, cause ext4 mesg dump.
Fixes: acf943e9768e ("ext4: fix checks for orphan inodes")
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
fs/ext4/ialloc.c | 1 -
fs/ext4/inode.c | 1 -
fs/ext4/super.c | 1 +
3 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index ba4fd9aba1c14de56b89ebbeb4597f7becf947ff..b20a1bf866abedf3a768ee8a147f108ea09ecb01 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -1293,7 +1293,6 @@ struct inode *__ext4_new_inode(struct mnt_idmap *idmap,
ei->i_csum_seed = ext4_chksum(csum, (__u8 *)&gen, sizeof(gen));
}
- ext4_clear_state_flags(ei); /* Only relevant on 32-bit archs */
ext4_set_inode_state(inode, EXT4_STATE_NEW);
ei->i_extra_isize = sbi->s_want_extra_isize;
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index a163c087137314c541ec10c011488c5392fb7011..bf6786d373ff57c32d5a84cfd73ea8a33cb68b16 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -5285,7 +5285,6 @@ struct inode *__ext4_iget(struct super_block *sb, unsigned long ino,
ei->i_projid = make_kprojid(&init_user_ns, i_projid);
set_nlink(inode, le16_to_cpu(raw_inode->i_links_count));
- ext4_clear_state_flags(ei); /* Only relevant on 32-bit archs */
ei->i_inline_off = 0;
ei->i_dir_start_lookup = 0;
ei->i_dtime = le32_to_cpu(raw_inode->i_dtime);
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 33e7c08c9529c357d291f40269863398753dc650..3dcc9410c09a55d5dce2dbff388a97bf4f133818 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1396,6 +1396,7 @@ static struct inode *ext4_alloc_inode(struct super_block *sb)
inode_set_iversion(&ei->vfs_inode, 1);
ei->i_flags = 0;
+ ext4_clear_state_flags(ei); /* Only relevant on 32-bit archs */
spin_lock_init(&ei->i_raw_lock);
ei->i_prealloc_node = RB_ROOT;
atomic_set(&ei->i_prealloc_active, 0);
---
base-commit: 9823120909776bbca58a3c55ef1f27d49283c1f3
change-id: 20251104-ext4-3f9647dcedd0
Best regards,
--
Haibo Chen <haibo.chen@nxp.com>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ext4: clear i_state_flags when alloc inode
2025-11-04 8:12 [PATCH] ext4: clear i_state_flags when alloc inode Haibo Chen
@ 2025-11-04 12:13 ` Jan Kara
2025-11-05 1:25 ` Zhang Yi
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Jan Kara @ 2025-11-04 12:13 UTC (permalink / raw)
To: Haibo Chen
Cc: Theodore Ts'o, Andreas Dilger, Zhang Yi, Jan Kara, linux-ext4,
linux-kernel, imx
On Tue 04-11-25 16:12:24, Haibo Chen wrote:
> i_state_flags used on 32-bit archs, need to clear this flag when
> alloc inode.
> Find this issue when umount ext4, sometimes track the inode as orphan
> accidently, cause ext4 mesg dump.
>
> Fixes: acf943e9768e ("ext4: fix checks for orphan inodes")
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Looks good to me. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ext4/ialloc.c | 1 -
> fs/ext4/inode.c | 1 -
> fs/ext4/super.c | 1 +
> 3 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
> index ba4fd9aba1c14de56b89ebbeb4597f7becf947ff..b20a1bf866abedf3a768ee8a147f108ea09ecb01 100644
> --- a/fs/ext4/ialloc.c
> +++ b/fs/ext4/ialloc.c
> @@ -1293,7 +1293,6 @@ struct inode *__ext4_new_inode(struct mnt_idmap *idmap,
> ei->i_csum_seed = ext4_chksum(csum, (__u8 *)&gen, sizeof(gen));
> }
>
> - ext4_clear_state_flags(ei); /* Only relevant on 32-bit archs */
> ext4_set_inode_state(inode, EXT4_STATE_NEW);
>
> ei->i_extra_isize = sbi->s_want_extra_isize;
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index a163c087137314c541ec10c011488c5392fb7011..bf6786d373ff57c32d5a84cfd73ea8a33cb68b16 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -5285,7 +5285,6 @@ struct inode *__ext4_iget(struct super_block *sb, unsigned long ino,
> ei->i_projid = make_kprojid(&init_user_ns, i_projid);
> set_nlink(inode, le16_to_cpu(raw_inode->i_links_count));
>
> - ext4_clear_state_flags(ei); /* Only relevant on 32-bit archs */
> ei->i_inline_off = 0;
> ei->i_dir_start_lookup = 0;
> ei->i_dtime = le32_to_cpu(raw_inode->i_dtime);
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 33e7c08c9529c357d291f40269863398753dc650..3dcc9410c09a55d5dce2dbff388a97bf4f133818 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1396,6 +1396,7 @@ static struct inode *ext4_alloc_inode(struct super_block *sb)
>
> inode_set_iversion(&ei->vfs_inode, 1);
> ei->i_flags = 0;
> + ext4_clear_state_flags(ei); /* Only relevant on 32-bit archs */
> spin_lock_init(&ei->i_raw_lock);
> ei->i_prealloc_node = RB_ROOT;
> atomic_set(&ei->i_prealloc_active, 0);
>
> ---
> base-commit: 9823120909776bbca58a3c55ef1f27d49283c1f3
> change-id: 20251104-ext4-3f9647dcedd0
>
> Best regards,
> --
> Haibo Chen <haibo.chen@nxp.com>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ext4: clear i_state_flags when alloc inode
2025-11-04 8:12 [PATCH] ext4: clear i_state_flags when alloc inode Haibo Chen
2025-11-04 12:13 ` Jan Kara
@ 2025-11-05 1:25 ` Zhang Yi
2025-11-08 3:22 ` Baokun Li
2025-11-17 19:13 ` Theodore Ts'o
3 siblings, 0 replies; 5+ messages in thread
From: Zhang Yi @ 2025-11-05 1:25 UTC (permalink / raw)
To: Haibo Chen, Theodore Ts'o, Andreas Dilger, Jan Kara
Cc: linux-ext4, linux-kernel, imx
On 11/4/2025 4:12 PM, Haibo Chen wrote:
> i_state_flags used on 32-bit archs, need to clear this flag when
> alloc inode.
> Find this issue when umount ext4, sometimes track the inode as orphan
> accidently, cause ext4 mesg dump.
>
> Fixes: acf943e9768e ("ext4: fix checks for orphan inodes")
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Looks good to me.
Reviewed-by: Zhang Yi <yi.zhang@huawei.com>
> ---
> fs/ext4/ialloc.c | 1 -
> fs/ext4/inode.c | 1 -
> fs/ext4/super.c | 1 +
> 3 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
> index ba4fd9aba1c14de56b89ebbeb4597f7becf947ff..b20a1bf866abedf3a768ee8a147f108ea09ecb01 100644
> --- a/fs/ext4/ialloc.c
> +++ b/fs/ext4/ialloc.c
> @@ -1293,7 +1293,6 @@ struct inode *__ext4_new_inode(struct mnt_idmap *idmap,
> ei->i_csum_seed = ext4_chksum(csum, (__u8 *)&gen, sizeof(gen));
> }
>
> - ext4_clear_state_flags(ei); /* Only relevant on 32-bit archs */
> ext4_set_inode_state(inode, EXT4_STATE_NEW);
>
> ei->i_extra_isize = sbi->s_want_extra_isize;
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index a163c087137314c541ec10c011488c5392fb7011..bf6786d373ff57c32d5a84cfd73ea8a33cb68b16 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -5285,7 +5285,6 @@ struct inode *__ext4_iget(struct super_block *sb, unsigned long ino,
> ei->i_projid = make_kprojid(&init_user_ns, i_projid);
> set_nlink(inode, le16_to_cpu(raw_inode->i_links_count));
>
> - ext4_clear_state_flags(ei); /* Only relevant on 32-bit archs */
> ei->i_inline_off = 0;
> ei->i_dir_start_lookup = 0;
> ei->i_dtime = le32_to_cpu(raw_inode->i_dtime);
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 33e7c08c9529c357d291f40269863398753dc650..3dcc9410c09a55d5dce2dbff388a97bf4f133818 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1396,6 +1396,7 @@ static struct inode *ext4_alloc_inode(struct super_block *sb)
>
> inode_set_iversion(&ei->vfs_inode, 1);
> ei->i_flags = 0;
> + ext4_clear_state_flags(ei); /* Only relevant on 32-bit archs */
> spin_lock_init(&ei->i_raw_lock);
> ei->i_prealloc_node = RB_ROOT;
> atomic_set(&ei->i_prealloc_active, 0);
>
> ---
> base-commit: 9823120909776bbca58a3c55ef1f27d49283c1f3
> change-id: 20251104-ext4-3f9647dcedd0
>
> Best regards,
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ext4: clear i_state_flags when alloc inode
2025-11-04 8:12 [PATCH] ext4: clear i_state_flags when alloc inode Haibo Chen
2025-11-04 12:13 ` Jan Kara
2025-11-05 1:25 ` Zhang Yi
@ 2025-11-08 3:22 ` Baokun Li
2025-11-17 19:13 ` Theodore Ts'o
3 siblings, 0 replies; 5+ messages in thread
From: Baokun Li @ 2025-11-08 3:22 UTC (permalink / raw)
To: Haibo Chen
Cc: Theodore Ts'o, Andreas Dilger, Zhang Yi, Jan Kara, linux-ext4,
linux-kernel, imx
On 2025-11-04 16:12, Haibo Chen wrote:
> i_state_flags used on 32-bit archs, need to clear this flag when
> alloc inode.
> Find this issue when umount ext4, sometimes track the inode as orphan
> accidently, cause ext4 mesg dump.
>
> Fixes: acf943e9768e ("ext4: fix checks for orphan inodes")
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Looks good. Feel free to add:
Reviewed-by: Baokun Li <libaokun1@huawei.com>
> ---
> fs/ext4/ialloc.c | 1 -
> fs/ext4/inode.c | 1 -
> fs/ext4/super.c | 1 +
> 3 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
> index ba4fd9aba1c14de56b89ebbeb4597f7becf947ff..b20a1bf866abedf3a768ee8a147f108ea09ecb01 100644
> --- a/fs/ext4/ialloc.c
> +++ b/fs/ext4/ialloc.c
> @@ -1293,7 +1293,6 @@ struct inode *__ext4_new_inode(struct mnt_idmap *idmap,
> ei->i_csum_seed = ext4_chksum(csum, (__u8 *)&gen, sizeof(gen));
> }
>
> - ext4_clear_state_flags(ei); /* Only relevant on 32-bit archs */
> ext4_set_inode_state(inode, EXT4_STATE_NEW);
>
> ei->i_extra_isize = sbi->s_want_extra_isize;
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index a163c087137314c541ec10c011488c5392fb7011..bf6786d373ff57c32d5a84cfd73ea8a33cb68b16 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -5285,7 +5285,6 @@ struct inode *__ext4_iget(struct super_block *sb, unsigned long ino,
> ei->i_projid = make_kprojid(&init_user_ns, i_projid);
> set_nlink(inode, le16_to_cpu(raw_inode->i_links_count));
>
> - ext4_clear_state_flags(ei); /* Only relevant on 32-bit archs */
> ei->i_inline_off = 0;
> ei->i_dir_start_lookup = 0;
> ei->i_dtime = le32_to_cpu(raw_inode->i_dtime);
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 33e7c08c9529c357d291f40269863398753dc650..3dcc9410c09a55d5dce2dbff388a97bf4f133818 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1396,6 +1396,7 @@ static struct inode *ext4_alloc_inode(struct super_block *sb)
>
> inode_set_iversion(&ei->vfs_inode, 1);
> ei->i_flags = 0;
> + ext4_clear_state_flags(ei); /* Only relevant on 32-bit archs */
> spin_lock_init(&ei->i_raw_lock);
> ei->i_prealloc_node = RB_ROOT;
> atomic_set(&ei->i_prealloc_active, 0);
>
> ---
> base-commit: 9823120909776bbca58a3c55ef1f27d49283c1f3
> change-id: 20251104-ext4-3f9647dcedd0
>
> Best regards,
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ext4: clear i_state_flags when alloc inode
2025-11-04 8:12 [PATCH] ext4: clear i_state_flags when alloc inode Haibo Chen
` (2 preceding siblings ...)
2025-11-08 3:22 ` Baokun Li
@ 2025-11-17 19:13 ` Theodore Ts'o
3 siblings, 0 replies; 5+ messages in thread
From: Theodore Ts'o @ 2025-11-17 19:13 UTC (permalink / raw)
To: Andreas Dilger, Zhang Yi, Jan Kara, Haibo Chen
Cc: Theodore Ts'o, linux-ext4, linux-kernel, imx
On Tue, 04 Nov 2025 16:12:24 +0800, Haibo Chen wrote:
> i_state_flags used on 32-bit archs, need to clear this flag when
> alloc inode.
> Find this issue when umount ext4, sometimes track the inode as orphan
> accidently, cause ext4 mesg dump.
>
>
Applied, thanks!
[1/1] ext4: clear i_state_flags when alloc inode
commit: 322a9e3c77253842617257af246cb5a0ac77851c
Best regards,
--
Theodore Ts'o <tytso@mit.edu>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-11-17 19:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-04 8:12 [PATCH] ext4: clear i_state_flags when alloc inode Haibo Chen
2025-11-04 12:13 ` Jan Kara
2025-11-05 1:25 ` Zhang Yi
2025-11-08 3:22 ` Baokun Li
2025-11-17 19:13 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox