From: Christoph Hellwig <hch@lst.de>
To: Joanne Koong <joannelkoong@gmail.com>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
Christoph Hellwig <hch@lst.de>,
changfengnan@bytedance.com,
Christian Brauner <brauner@kernel.org>,
Theodore Ts'o <tytso@mit.edu>, Carlos Maiolino <cem@kernel.org>,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/3] iomap: decouple simple direct I/O reads from iomap_dio_rw
Date: Tue, 28 Jul 2026 05:52:17 +0200 [thread overview]
Message-ID: <20260728035217.GA19245@lst.de> (raw)
In-Reply-To: <CAJnrk1Z9wxXf+=d-+5VMcCiDiy4Q7UsBGvzwaPQtAok6avjKPw@mail.gmail.com>
On Fri, Jul 24, 2026 at 02:39:49PM -0700, Joanne Koong wrote:
> > > - ret = iomap_dio_rw(iocb, to, &ext4_iomap_ops, NULL, 0, NULL, 0);
> > > + ret = iomap_dio_read_simple(iocb, to, ext4_iomap_begin);
> >
> > I was kinda wondering if you can pass ext4_iomap_ops.iomap_begin here
> > to avoid the declaration in ext4.h?
>
> I think it ends up being a bit cleaner to do it here, otherwise the
> subsequent ext4 patch that replaces .iomap_begin()/.iomap_end() with
> .iomap_next() will have to do it.
Yes, we'd just do the work twice otherwise.
next prev parent reply other threads:[~2026-07-28 3:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 5:01 decouple simple direct I/O reads from iomap_dio_rw v2 Christoph Hellwig
2026-07-23 5:01 ` [PATCH 1/3] iomap: split iomap_iter() logic into iomap_iter_next() Christoph Hellwig
2026-07-23 16:43 ` Darrick J. Wong
2026-07-23 5:01 ` [PATCH 2/3] iomap: decouple simple direct I/O reads from iomap_dio_rw Christoph Hellwig
2026-07-23 16:47 ` Darrick J. Wong
2026-07-24 21:39 ` Joanne Koong
2026-07-28 3:52 ` Christoph Hellwig [this message]
2026-07-23 5:01 ` [PATCH 3/3] iomap: use GFP_NOWAIT when application for iomap_dio_simple allocations Christoph Hellwig
2026-07-23 16:43 ` Darrick J. Wong
2026-07-24 21:50 ` decouple simple direct I/O reads from iomap_dio_rw v2 Joanne Koong
-- strict thread matches above, loose matches on Subject: below --
2026-07-22 12:49 decouple simple direct I/O reads from iomap_dio_rw Christoph Hellwig
2026-07-22 12:49 ` [PATCH 2/3] iomap: " Christoph Hellwig
2026-07-22 19:03 ` Joanne Koong
2026-07-23 2:17 ` changfengnan
2026-07-23 4:55 ` Christoph Hellwig
2026-07-23 4:53 ` Christoph Hellwig
2026-07-23 15:10 ` Darrick J. Wong
2026-07-23 16:08 ` Theodore Tso
2026-07-24 12:47 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260728035217.GA19245@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=changfengnan@bytedance.com \
--cc=djwong@kernel.org \
--cc=joannelkoong@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox