Linux EXT4 FS development
 help / color / mirror / Atom feed
From: Carlos Maiolino <cem@kernel.org>
To: Theodore Tso <tytso@mit.edu>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
	Christoph Hellwig <hch@lst.de>,
	 Joanne Koong <joannelkoong@gmail.com>,
	changfengnan@bytedance.com,
	 Christian Brauner <brauner@kernel.org>,
	linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
	 linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/3] iomap: decouple simple direct I/O reads from iomap_dio_rw
Date: Fri, 24 Jul 2026 14:47:58 +0200	[thread overview]
Message-ID: <amNerp4LwjSkHS5t@andromeda.toxiclabs.cc> (raw)
In-Reply-To: <amI3Kf3lFz4FMqXh@mit.edu>

On Thu, Jul 23, 2026 at 12:08:21PM -0400, Theodore Tso wrote:
> On Thu, Jul 23, 2026 at 08:10:21AM -0500, Darrick J. Wong wrote:
> > > Yes.  Sashiko also reported that yesterday and I replied with a patch,
> > > but I now noticed the report and thus my reply only went to me,
> > > a sashiko-review list and Ted, but not everone else or the lists.
> > > 
> > > WTF?
> > 
> > Sashiko doesn't email the lists by default, and I don't think we want to
> > turn that on for the fsdevel firehose.
> 
> Whether or not the review goes to a mailing list is up to each
> subsystem to determine.  Some people have violently objected to the
> review going to the mailing list, which is why it's optional.
> 
> I have asked to have ext4 reviews to be cc'ed to the linux-ext4
> list[1].  It would be up to the VFS maintainers whether or not we want
> to enable it for linux-fsdevel.
> 
> [1] https://github.com/sashiko-dev/sashiko/pull/365
> 
> The XFS maintainers can request if patches cc'ed to linux-fs should
> get reviewed and sent back to authors and/or the maintainers and/or
> the linux-fs mailing list.  You can either ask the Sashiko devs to
> edit the email_policy.toml file, or you can send a pull request yourself.
> 

IIRC the discussion we had a while back was to keep the reviews emailed
to authors only...

Now I wonder how feasible would be to have a "linux-xfs-review" list to
send sashiko reviews to, then people opt-in to it? Would it be overkill?

  reply	other threads:[~2026-07-24 12:48 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22 12:49 decouple simple direct I/O reads from iomap_dio_rw Christoph Hellwig
2026-07-22 12:49 ` [PATCH 1/3] iomap: split iomap_iter() logic into iomap_iter_next() Christoph Hellwig
2026-07-23  2:06   ` changfengnan
2026-07-22 12:49 ` [PATCH 2/3] iomap: decouple simple direct I/O reads from iomap_dio_rw Christoph Hellwig
2026-07-22 19:03   ` Joanne Koong
2026-07-23  2:17     ` changfengnan
2026-07-23  4:55       ` Christoph Hellwig
2026-07-23  4:53     ` Christoph Hellwig
2026-07-23 15:10       ` Darrick J. Wong
2026-07-23 16:08         ` Theodore Tso
2026-07-24 12:47           ` Carlos Maiolino [this message]
2026-07-28  4:01             ` selective Sashiko replies, was: " Christoph Hellwig
2026-07-28 14:27               ` Jakub Kicinski
2026-07-28 14:42                 ` Theodore Tso
2026-07-22 12:49 ` [PATCH 3/3] iomap: use GFP_NOWAIT when application for iomap_dio_simple allocations Christoph Hellwig
2026-07-22 21:01   ` Joanne Koong
2026-07-23  2:06     ` changfengnan
  -- strict thread matches above, loose matches on Subject: below --
2026-07-23  5:01 decouple simple direct I/O reads from iomap_dio_rw v2 Christoph Hellwig
2026-07-23  5:01 ` [PATCH 2/3] iomap: decouple simple direct I/O reads from iomap_dio_rw Christoph Hellwig
2026-07-23 16:47   ` Darrick J. Wong
2026-07-24 21:39     ` Joanne Koong
2026-07-28  3:52       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amNerp4LwjSkHS5t@andromeda.toxiclabs.cc \
    --to=cem@kernel.org \
    --cc=brauner@kernel.org \
    --cc=changfengnan@bytedance.com \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=joannelkoong@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox