From: Eric Biggers <ebiggers@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: linux-ext4@vger.kernel.org, stable@vger.kernel.org,
Zhihao Cheng <chengzhihao1@huawei.com>, Jan Kara <jack@suse.cz>,
Yao Kai <yaokai34@huawei.com>, Zhang Yi <yi.zhang@huawei.com>,
Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH 6.12] ext4: validate readdir offset before accessing dirent
Date: Tue, 27 Oct 2026 18:13:27 -0700 [thread overview]
Message-ID: <20261028011327.GA1893@quark> (raw)
In-Reply-To: <sashiko-outbox-187298@kernel.org>
[+Cc recipients that Sashiko dropped]
Should the Sashiko configuration for linux-ext4 be updated to enable
reply-all? That would be my preference, and various other lists already
use that setting.
On Wed, Oct 28, 2026 at 01:02:25AM +0000, sashiko-bot@kernel.org wrote:
> [Severity: Medium]
> What happens in ext4_readdir() if a corrupted de->rec_len in the rescan loop
> advances i past sb->s_blocksize?
>
> In fs/ext4/dir.c:ext4_readdir(), when !inode_eq_iversion(inode, info->cookie)
> triggers a rescan (for instance after ext4_dir_llseek()), the loop only checks
> the lower bound of de->rec_len before adding it to i and updating ctx->pos:
Sounds like this fix was incomplete but the backport is still safe.
- Eric
prev parent reply other threads:[~2026-10-28 1:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 0:37 [PATCH 6.12] ext4: validate readdir offset before accessing dirent Eric Biggers
2026-10-28 1:02 ` sashiko-bot
2026-10-28 1:13 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028011327.GA1893@quark \
--to=ebiggers@kernel.org \
--cc=chengzhihao1@huawei.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yaokai34@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox