From: Christoph Hellwig <hch@lst.de>
To: Brian Foster <bfoster@redhat.com>
Cc: Tal Zussman <tz2294@columbia.edu>,
fstests@vger.kernel.org, Zorro Lang <zlang@kernel.org>,
Christoph Hellwig <hch@lst.de>,
linux-ext4@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
"Darrick J. Wong" <djwong@kernel.org>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 2/3] common/rc: pass -V 1 when probing pwrite and pread -U
Date: Wed, 28 Oct 2026 17:00:47 +0100 [thread overview]
Message-ID: <20261028160047.GC20501@lst.de> (raw)
In-Reply-To: <atoOzsNo8zUTrxVj@bfoster>
On Thu, Oct 22, 2026 at 09:25:34AM -0400, Brian Foster wrote:
> > - -c "pread $param 0 4k" $testfile 2>&1`
> > - param_checked="$param"
> > + -c "pread $pread_opts $param 0 4k" $testfile 2>&1`
> > + param_checked="$pread_opts $param"
> > ;;
>
> I find it a little odd that we auto add command related options here
> even though the test still needs to know to use those options for the
> commands to work correctly. But I guess there's precedent for it, so oh
> well:
Same. Given how annoying the required -V 1 is, maybe this defaulting
should go into xfs_io itself so that -U, -D and co can be used without
manually specifying -V ?
next prev parent reply other threads:[~2026-10-28 16:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 20:54 [PATCH 0/3] fstests: test that RWF_DONTCACHE I/O drops its folios Tal Zussman
2026-10-15 20:54 ` [PATCH 1/3] common/rc: probe pread options with a real read Tal Zussman
2026-10-22 13:25 ` Brian Foster
2026-10-28 15:59 ` Christoph Hellwig
2026-10-15 20:54 ` [PATCH 2/3] common/rc: pass -V 1 when probing pwrite and pread -U Tal Zussman
2026-10-22 13:25 ` Brian Foster
2026-10-28 16:00 ` Christoph Hellwig [this message]
2026-10-15 20:54 ` [PATCH 3/3] generic/810: check that RWF_DONTCACHE I/O drops its folios Tal Zussman
2026-10-22 13:25 ` Brian Foster
2026-10-28 16:01 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028160047.GC20501@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bfoster@redhat.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tz2294@columbia.edu \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox