Re: [PATCH 1/3] common/rc: probe pread options with a real read

[Brian Foster <bfoster@redhat.com>]

On Thu, Oct 15, 2026 at 04:54:02PM -0400, Tal Zussman wrote:
> _require_xfs_io_command has no pread case, so a pread option falls back
> to a grep of the help text, and that only matches options that take an
> argument. A bare -U is reported as unsupported even when xfs_io has it.
> Add a pread case that does a real read with the option, like the pwrite
> case does.
> 
> Signed-off-by: Tal Zussman <tz2294@columbia.edu>
> ---

Reviewed-by: Brian Foster <bfoster@redhat.com>

>  common/rc | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/common/rc b/common/rc
> index 1eccd60c..945c9e42 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -3120,6 +3120,11 @@ _require_xfs_io_command()
>  		        "pwrite $pwrite_opts $param 0 $write_size" $testfile 2>&1`
>  		param_checked="$pwrite_opts $param"
>  		;;
> +	"pread")
> +		testio=`$XFS_IO_PROG -f -c "pwrite 0 4k" \
> +			-c "pread $param 0 4k" $testfile 2>&1`
> +		param_checked="$param"
> +		;;
>  	"scrub"|"repair")
>  		test -z "$param" && param="probe"
>  		testio=`$XFS_IO_PROG -x -c "$command $param" $TEST_DIR 2>&1`
> 
> -- 
> 2.39.5
> 
>