From: Eric Biggers <ebiggers@kernel.org>
To: Andrey Albershteyn <aalbersh@kernel.org>
Cc: hch@lst.de, fsverity@lists.linux.dev, dsterba@suse.com,
linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
brauner@kernel.org, viro@zeniv.linux.org.uk, jaegeuk@kernel.org,
chao@kernel.org, tytso@mit.edu
Subject: Re: [PATCH v2 4/5] ext4: use I_VERITY_BUILDING instead of private flags
Date: Tue, 10 Nov 2026 15:01:08 -0800 [thread overview]
Message-ID: <20261110230108.GH1907@quark> (raw)
In-Reply-To: <20261105115532.613467-5-aalbersh@kernel.org>
On Thu, Nov 05, 2026 at 12:55:29PM +0100, Andrey Albershteyn wrote:
> /*
> - * Write all pages (both data and verity metadata). Note that this must
> - * happen before clearing EXT4_STATE_VERITY_IN_PROGRESS; otherwise pages
> - * beyond i_size won't be written properly. For crash consistency, this
> - * also must happen before the verity inode flag gets persisted.
> + * Write all pages (both data and verity metadata). For crash
> + * consistency, this also must happen before the verity inode flag gets
> + * persisted.
> */
> err = filemap_write_and_wait(inode->i_mapping);
The deleted sentence (which wasn't deleted properly, as it left the
"this also must happen" clause dangling) actually still applies. Just
it should be updated to use the new flag name, or else refer to
->end_enable_verity() returning instead.
- Eric
next prev parent reply other threads:[~2026-11-10 23:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 11:55 [PATCH v2 0/5] fsverity: lift ioctl() input masking and runtime inode flag to VFS Andrey Albershteyn
2026-11-05 11:55 ` [PATCH v2 1/5] fsverity: strip FS_VERITY_FL from FS_IOC_SETFLAGS Andrey Albershteyn
2026-11-05 12:03 ` [f2fs-dev] " sashiko-bot
2026-11-06 10:26 ` Christoph Hellwig
2026-11-10 22:32 ` Eric Biggers
2026-11-05 11:55 ` [PATCH v2 2/5] fsverity: add I_VERITY_BUILDING inode state flag Andrey Albershteyn
2026-11-05 12:03 ` [f2fs-dev] " sashiko-bot
2026-11-06 10:26 ` Christoph Hellwig
2026-11-10 22:35 ` Eric Biggers
2026-11-10 22:37 ` Eric Biggers
2026-11-10 22:40 ` Eric Biggers
2026-11-10 22:57 ` Eric Biggers
2026-11-05 11:55 ` [PATCH v2 3/5] btrfs: use I_VERITY_BUILDING instead of private flags Andrey Albershteyn
2026-11-05 12:03 ` sashiko-bot
2026-11-06 10:26 ` Christoph Hellwig
2026-11-05 11:55 ` [PATCH v2 4/5] ext4: " Andrey Albershteyn
2026-11-05 12:01 ` [f2fs-dev] " sashiko-bot
2026-11-06 10:27 ` Christoph Hellwig
2026-11-10 23:01 ` Eric Biggers [this message]
2026-11-05 11:55 ` [PATCH v2 5/5] f2fs: " Andrey Albershteyn
2026-11-05 12:03 ` [f2fs-dev] " sashiko-bot
2026-11-06 10:27 ` Christoph Hellwig
2026-11-10 23:03 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110230108.GH1907@quark \
--to=ebiggers@kernel.org \
--cc=aalbersh@kernel.org \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=dsterba@suse.com \
--cc=fsverity@lists.linux.dev \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox