[tytso-ext4:pu 9/50] fs/ext4/fast_commit-test.c:1145:1: warning: the frame size of 1476 bytes is larger than 1280 bytes

[tytso-ext4:pu 9/50] fs/ext4/fast_commit-test.c:1145:1: warning: the frame size of 1476 bytes is larger than 1280 bytes

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git pu
head:   246d715a48c25a74ac372dda5e10d8f69f89b50a
commit: 781558b8eddee2d9384ea3f0ed4901b8b329cb24 [9/50] ext4: add KUnit tests for fs/ext4/fast_commit.c
config: csky-allmodconfig (https://download.01.org/0day-ci/archive/20261113/202611132301.FRexPvKk-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 16.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261113/202611132301.FRexPvKk-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611132301.FRexPvKk-lkp@intel.com/

All warnings (new ones prefixed by >>):

   fs/ext4/fast_commit-test.c: In function 'test_fc_init_and_eligibility':
>> fs/ext4/fast_commit-test.c:1145:1: warning: the frame size of 1476 bytes is larger than 1280 bytes [-Wframe-larger-than=]
    1145 | }
         | ^


vim +1145 fs/ext4/fast_commit-test.c

  1067	
  1068	/* =========================================================================
  1069	 * 1. Initialization, Eligibility, and Snapshot Stat Helpers
  1070	 * =========================================================================
  1071	 */
  1072	
  1073	static void test_fc_init_and_eligibility(struct kunit *test)
  1074	{
  1075		struct fc_test_ctx *ctx = test->priv;
  1076		struct super_block *sb = ctx->sb;
  1077		struct inode *inode = get_mock_inode(ctx, TEST_FILE1_INO);
  1078		struct ext4_inode_info *ei = EXT4_I(inode);
  1079		journal_t tmp_journal = {};
  1080		atomic64_t max_stat = ATOMIC64_INIT(0);
  1081		int snap_err = EXT4_FC_SNAP_ERR_NONE;
  1082	
  1083		/*
  1084		 * 1) ext4_fc_init sets j_fc_replay_callback unconditionally, but sets
  1085		 *    j_fc_cleanup_callback only when JOURNAL_FAST_COMMIT is enabled.
  1086		 */
  1087		clear_opt2(sb, JOURNAL_FAST_COMMIT);
  1088		ext4_fc_init(sb, &tmp_journal);
  1089		KUNIT_EXPECT_NOT_NULL(test, tmp_journal.j_fc_replay_callback);
  1090		KUNIT_EXPECT_NULL(test, tmp_journal.j_fc_cleanup_callback);
  1091	
  1092		set_opt2(sb, JOURNAL_FAST_COMMIT);
  1093		ext4_fc_init(sb, &tmp_journal);
  1094		KUNIT_EXPECT_NOT_NULL(test, tmp_journal.j_fc_replay_callback);
  1095		KUNIT_EXPECT_NOT_NULL(test, tmp_journal.j_fc_cleanup_callback);
  1096	
  1097		/* 2) ext4_fc_init_inode clears state and resets ranges */
  1098		ei->i_fc_lblk_start = 42;
  1099		ei->i_fc_lblk_len = 10;
  1100		ext4_set_inode_state(inode, EXT4_STATE_FC_COMMITTING);
  1101		ext4_set_inode_state(inode, EXT4_STATE_FC_REQUEUE);
  1102		ext4_fc_init_inode(inode);
  1103		KUNIT_EXPECT_EQ(test, ei->i_fc_lblk_start, 0U);
  1104		KUNIT_EXPECT_EQ(test, ei->i_fc_lblk_len, 0U);
  1105		KUNIT_EXPECT_FALSE(test,
  1106				   ext4_test_inode_state(inode, EXT4_STATE_FC_COMMITTING));
  1107		KUNIT_EXPECT_FALSE(test,
  1108				   ext4_test_inode_state(inode, EXT4_STATE_FC_REQUEUE));
  1109		KUNIT_EXPECT_TRUE(test, list_empty(&ei->i_fc_list));
  1110		KUNIT_EXPECT_TRUE(test, list_empty(&ei->i_fc_dilist));
  1111		KUNIT_EXPECT_NULL(test, ei->i_fc_snap);
  1112	
  1113		/* 3) ext4_fc_disabled and ext4_fc_eligible transitions */
  1114		KUNIT_EXPECT_FALSE(test, ext4_fc_disabled_test(sb));
  1115		KUNIT_EXPECT_TRUE(test, ext4_fc_eligible_test(sb));
  1116	
  1117		ctx->sbi->s_mount_state |= EXT4_FC_REPLAY;
  1118		KUNIT_EXPECT_TRUE(test, ext4_fc_disabled_test(sb));
  1119		KUNIT_EXPECT_FALSE(test, ext4_fc_eligible_test(sb));
  1120		ctx->sbi->s_mount_state &= ~EXT4_FC_REPLAY;
  1121	
  1122		ext4_set_mount_flag(sb, EXT4_MF_FC_INELIGIBLE);
  1123		KUNIT_EXPECT_FALSE(test, ext4_fc_disabled_test(sb));
  1124		KUNIT_EXPECT_FALSE(test, ext4_fc_eligible_test(sb));
  1125		ext4_clear_mount_flag(sb, EXT4_MF_FC_INELIGIBLE);
  1126	
  1127		clear_opt2(sb, JOURNAL_FAST_COMMIT);
  1128		KUNIT_EXPECT_TRUE(test, ext4_fc_disabled_test(sb));
  1129		KUNIT_EXPECT_FALSE(test, ext4_fc_eligible_test(sb));
  1130		set_opt2(sb, JOURNAL_FAST_COMMIT);
  1131	
  1132		/* 4) ext4_fc_set_snap_err preserves first error */
  1133		ext4_fc_set_snap_err_test(&snap_err, EXT4_FC_SNAP_ERR_ES_MISS);
  1134		KUNIT_EXPECT_EQ(test, snap_err, (int)EXT4_FC_SNAP_ERR_ES_MISS);
  1135		ext4_fc_set_snap_err_test(&snap_err, EXT4_FC_SNAP_ERR_NOMEM);
  1136		KUNIT_EXPECT_EQ(test, snap_err, (int)EXT4_FC_SNAP_ERR_ES_MISS);
  1137	
  1138		/* 5) ext4_fc_snap_stats_update_max monotonically updates max */
  1139		ext4_fc_snap_stats_update_max_test(&max_stat, 100);
  1140		KUNIT_EXPECT_EQ(test, atomic64_read(&max_stat), 100LL);
  1141		ext4_fc_snap_stats_update_max_test(&max_stat, 50);
  1142		KUNIT_EXPECT_EQ(test, atomic64_read(&max_stat), 100LL);
  1143		ext4_fc_snap_stats_update_max_test(&max_stat, 250);
  1144		KUNIT_EXPECT_EQ(test, atomic64_read(&max_stat), 250LL);
> 1145	}
  1146	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki