From: Theodore Tso <tytso@MIT.EDU>
To: NamJae Jeon <linkinjeon@gmail.com>
Cc: Theodore Tso <tytso@mit.edu>,
David Rientjes <rientjes@google.com>,
linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org,
Amit Sahrawat <amit.sahrawat83@gmail.com>
Subject: Re: [PATCH] ext4: slab caches set to SLAB_MEM_SPREAD flags.
Date: Sat, 19 Nov 2011 16:14:01 -0500 [thread overview]
Message-ID: <2F5A5082-690F-4C74-A92F-6CC157489B46@mit.edu> (raw)
In-Reply-To: <CAKYAXd91gcPbfAqRRkW7HhxRDXstzGVRbwqzve40z6BTDEj4_w@mail.gmail.com>
On Nov 19, 2011, at 10:40 AM, NamJae Jeon wrote:
> Thanks for your opinion.
> Have you thought that mem spread flags is not needed in group info
> caches same with page_io and mballoc ?
The group info structures are long lived structures that live a long time and will likely be accessed by many NUMA nodes. So setting the men spread flag for the group info cache is more likely to be useful. My guess is that any benefit will be extremely hard to measure (especially since the amount of memory used by the group info structures is a pittance compared to the memory used by the inode cache), but at least theoretically it would be sound to have that flag set with the group info slab cache.
Regards,
-- Ted
next prev parent reply other threads:[~2011-11-19 21:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 15:04 [PATCH] ext4: slab caches set to SLAB_MEM_SPREAD flags Namjae Jeon
2011-11-16 15:51 ` Theodore Tso
2011-11-16 21:52 ` David Rientjes
2011-11-17 5:11 ` Amit Sahrawat
2011-11-17 5:35 ` NamJae Jeon
2011-11-17 15:11 ` Theodore Tso
2011-11-17 21:34 ` Theodore Tso
2011-11-19 13:52 ` NamJae Jeon
2011-11-19 14:42 ` Theodore Tso
2011-11-19 15:40 ` NamJae Jeon
2011-11-19 21:14 ` Theodore Tso [this message]
2011-11-19 22:22 ` NamJae Jeon
2011-11-19 21:06 ` Theodore Tso
2011-11-19 22:16 ` NamJae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2F5A5082-690F-4C74-A92F-6CC157489B46@mit.edu \
--to=tytso@mit.edu \
--cc=amit.sahrawat83@gmail.com \
--cc=linkinjeon@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox