public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Theodore Tso <tytso@mit.edu>
Cc: Namjae Jeon <linkinjeon@gmail.com>,
	linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org,
	Amit Sahrawat <amit.sahrawat83@gmail.com>
Subject: Re: [PATCH] ext4: slab caches set to SLAB_MEM_SPREAD flags.
Date: Wed, 16 Nov 2011 13:52:46 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.00.1111161347000.16596@chino.kir.corp.google.com> (raw)
In-Reply-To: <47270FB7-96AC-4F41-98D3-9AD469080DBE@mit.edu>

On Wed, 16 Nov 2011, Theodore Tso wrote:

> On Nov 16, 2011, at 10:04 AM, Namjae Jeon wrote:
> 
> > If slab caches set to SLAB_MEM_SPREAD flags, The allocation is spread 
> > evenly over all the memory nodes instead of favoring allocation on the 
> > node local to current cpu.
> 
> And why do you think this is a good thing?   For mballoc in particular, 
> the data structures are used immediately and then freed immediately --- 
> on the local node, so using a non-local memory just makes things worse 
> in a NUMA system.
> 

I don't think this has the effect that Namjae thinks it does: this is only 
useful for CONFIG_SLAB and when you have cpusets enabled with 
cpuset.memory_spread_slab set.

To test how useful it is, you should enable CONFIG_SLAB and then mount 
cpusets, set cpuset.memory_spread_slab, and create an MPOL_INTERLEAVE 
mempolicy over all online nodes.  This will have the same effect as adding 
SLAB_MEM_SPREAD to these slab caches (it just doesn't require the 
mempolicy) and will be able to quantify the effects without any changes to 
the kernel at all.

  reply	other threads:[~2011-11-16 21:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-16 15:04 [PATCH] ext4: slab caches set to SLAB_MEM_SPREAD flags Namjae Jeon
2011-11-16 15:51 ` Theodore Tso
2011-11-16 21:52   ` David Rientjes [this message]
2011-11-17  5:11     ` Amit Sahrawat
2011-11-17  5:35       ` NamJae Jeon
2011-11-17 15:11         ` Theodore Tso
2011-11-17 21:34           ` Theodore Tso
2011-11-19 13:52             ` NamJae Jeon
2011-11-19 14:42               ` Theodore Tso
2011-11-19 15:40                 ` NamJae Jeon
2011-11-19 21:14                   ` Theodore Tso
2011-11-19 22:22                     ` NamJae Jeon
2011-11-19 21:06       ` Theodore Tso
2011-11-19 22:16         ` NamJae Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1111161347000.16596@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=amit.sahrawat83@gmail.com \
    --cc=linkinjeon@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox